From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ronit Halder <ronit.crj@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
tranmanphong@gmail.com, linux-kernel@vger.kernel.org,
linux@rasmusvillemoes.dk, riandrews@android.com,
elfring@users.sourceforge.net, arve@android.com,
sumit.semwal@linaro.org
Subject: Re: [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue
Date: Thu, 9 Jul 2015 11:56:34 +0530 [thread overview]
Message-ID: <20150709062634.GA10284@sudip-PC> (raw)
In-Reply-To: <1436422151-8383-1-git-send-email-ronit.crj@gmail.com>
On Thu, Jul 09, 2015 at 11:39:11AM +0530, Ronit Halder wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Ronit Halder <ronit.crj@gmail.com>
Greg has commented in your v1 that it is a false positive. See that:
#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
so blank line will not be required here.
regards
sudip
prev parent reply other threads:[~2015-07-09 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 6:09 [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue Ronit Halder
2015-07-09 6:26 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709062634.GA10284@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=elfring@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=riandrews@android.com \
--cc=ronit.crj@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox