* [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue
@ 2015-07-09 6:09 Ronit Halder
2015-07-09 6:26 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: Ronit Halder @ 2015-07-09 6:09 UTC (permalink / raw)
To: gregkh
Cc: arve, riandrews, sumit.semwal, mitchelh, tranmanphong, ronit.crj,
elfring, linux, devel, linux-kernel
Fixed a coding style issue.
Signed-off-by: Ronit Halder <ronit.crj@gmail.com>
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
struct ion_buffer *buffer;
struct dma_buf *dmabuf;
bool valid_handle;
+
DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
mutex_lock(&client->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue
2015-07-09 6:09 [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue Ronit Halder
@ 2015-07-09 6:26 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2015-07-09 6:26 UTC (permalink / raw)
To: Ronit Halder
Cc: gregkh, devel, tranmanphong, linux-kernel, linux, riandrews,
elfring, arve, sumit.semwal
On Thu, Jul 09, 2015 at 11:39:11AM +0530, Ronit Halder wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Ronit Halder <ronit.crj@gmail.com>
Greg has commented in your v1 that it is a false positive. See that:
#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
so blank line will not be required here.
regards
sudip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-09 6:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-09 6:09 [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue Ronit Halder
2015-07-09 6:26 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox