From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbbGIIqh (ORCPT ); Thu, 9 Jul 2015 04:46:37 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:34844 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbGIIqY (ORCPT ); Thu, 9 Jul 2015 04:46:24 -0400 Date: Thu, 9 Jul 2015 10:46:33 +0200 From: Johan Hovold To: Johannes Thumshirn Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: Destroy serial_minors IDR on module exit Message-ID: <20150709084633.GA18161@localhost> References: <1436369197-31369-1-git-send-email-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436369197-31369-1-git-send-email-jthumshirn@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08, 2015 at 05:26:37PM +0200, Johannes Thumshirn wrote: > Destroy serial_minors IDR on module exit, reclaiming the allocated memory. > > This was detected by the following semantic patch (written by Luis Rodriguez > ) > > @ defines_module_init @ > declarer name module_init, module_exit; > declarer name DEFINE_IDR; > identifier init; > @@ > > module_init(init); > > @ defines_module_exit @ > identifier exit; > @@ > > module_exit(exit); > > @ declares_idr depends on defines_module_init && defines_module_exit @ > identifier idr; > @@ > > DEFINE_IDR(idr); > > @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ > identifier declares_idr.idr, defines_module_exit.exit; > @@ > > exit(void) > { > ... > idr_destroy(&idr); > ... > } > > @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ > identifier declares_idr.idr, defines_module_exit.exit; > @@ > > exit(void) > { > ... > +idr_destroy(&idr); > } > > > Signed-off-by: Johannes Thumshirn Applied, thanks. Johan