From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbGII5A (ORCPT ); Thu, 9 Jul 2015 04:57:00 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:36647 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbbGII45 (ORCPT ); Thu, 9 Jul 2015 04:56:57 -0400 Date: Thu, 9 Jul 2015 10:57:06 +0200 From: Johan Hovold To: Johannes Thumshirn Cc: Oliver Neukum , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cdc-acm: Destroy acm_minors IDR on module exit Message-ID: <20150709085706.GB18161@localhost> References: <1436369142-31303-1-git-send-email-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436369142-31303-1-git-send-email-jthumshirn@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08, 2015 at 05:25:42PM +0200, Johannes Thumshirn wrote: > Destroy acm_minors IDR on module exit, reclaiming the allocated memory. > Signed-off-by: Johannes Thumshirn > --- > drivers/usb/class/cdc-acm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index 519a77b..b30e742 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -1944,6 +1944,7 @@ static void __exit acm_exit(void) > usb_deregister(&acm_driver); > tty_unregister_driver(acm_tty_driver); > put_tty_driver(acm_tty_driver); > + idr_destroy(&acm_minors); > } > > module_init(acm_init); Acked-by: Johan Hovold No stable-tag needed as idr wasn't used before 4.2. Thanks, Johan