From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064AbbGIGgx (ORCPT ); Thu, 9 Jul 2015 02:36:53 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:9191 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbbGIGgp (ORCPT ); Thu, 9 Jul 2015 02:36:45 -0400 Date: Thu, 9 Jul 2015 14:35:52 +0800 From: Jisheng Zhang To: Lorenzo Pieralisi CC: "linux@arm.linux.org.uk" , Will Deacon , Mark Rutland , "daniel.lezcano@linaro.org" , Catalin Marinas , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/2] arm: kernel: implement cpuidle_ops with psci backend Message-ID: <20150709143552.7f1f83ce@xhacker> In-Reply-To: <20150708173458.GB10589@red-moon> References: <1436359868-6176-1-git-send-email-jszhang@marvell.com> <1436359868-6176-3-git-send-email-jszhang@marvell.com> <20150708173458.GB10589@red-moon> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-07-09_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507090112 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Lorenzo, On Wed, 8 Jul 2015 18:34:58 +0100 Lorenzo Pieralisi wrote: > On Wed, Jul 08, 2015 at 01:51:08PM +0100, Jisheng Zhang wrote: > > This patch implements cpuidle_ops using psci. After this patch, we can > > use cpuidle-arm.c with psci backend for both arm and arm64. > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/arm/kernel/Makefile | 1 + > > arch/arm/kernel/psci_cpuidle.c | 29 +++++++++++++++++++++++++++++ > > 2 files changed, 30 insertions(+) > > create mode 100644 arch/arm/kernel/psci_cpuidle.c > > > > diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile > > index 3b995f5..96383d8 100644 > > --- a/arch/arm/kernel/Makefile > > +++ b/arch/arm/kernel/Makefile > > @@ -91,6 +91,7 @@ obj-$(CONFIG_ARM_VIRT_EXT) += hyp-stub.o > > ifeq ($(CONFIG_ARM_PSCI),y) > > obj-y += psci-call.o > > obj-$(CONFIG_SMP) += psci_smp.o > > +obj-$(CONFIG_CPU_IDLE) += psci_cpuidle.o > > endif > > > > extra-y := $(head-y) vmlinux.lds > > diff --git a/arch/arm/kernel/psci_cpuidle.c b/arch/arm/kernel/psci_cpuidle.c > > new file mode 100644 > > index 0000000..ae85d97 > > --- /dev/null > > +++ b/arch/arm/kernel/psci_cpuidle.c > > @@ -0,0 +1,29 @@ > > +/* > > + * Copyright (C) 2015 Marvell Technology Group Ltd. > > + * Author: Jisheng Zhang > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > + > > +#include > > +#include > > + > > +#include > > + > > +static int psci_cpuidle_suspend(int cpu, unsigned long arg) > > +{ > > + return cpu_psci_cpu_suspend(arg); > > +} > > + > > +static int psci_cpuidle_init(struct device_node *node, int cpu) > > +{ > > + return cpu_psci_cpu_init_idle(cpu); > > +} > > It probably makes sense to change the prototypes now that there is > just one cpuidle ops merged for arm, better now than later. Good idea. I will do as you suggested. Thanks a lot, Jisheng > > I am not too fussed about leaving these shims, but I think this can > save us some time in the future. > > Daniel what do you think ? > > Lorenzo > > > + > > +static struct cpuidle_ops psci_cpuidle_ops __initdata = { > > + .suspend = psci_cpuidle_suspend, > > + .init = psci_cpuidle_init, > > +}; > > +CPUIDLE_METHOD_OF_DECLARE(psci_cpuidle, "psci", &psci_cpuidle_ops); > > -- > > 2.1.4 > >