From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753436AbbGIQUl (ORCPT ); Thu, 9 Jul 2015 12:20:41 -0400 Received: from gundega.hpl.hp.com ([192.6.19.190]:49616 "EHLO gundega.hpl.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbbGIQUe (ORCPT ); Thu, 9 Jul 2015 12:20:34 -0400 Date: Thu, 9 Jul 2015 09:20:17 -0700 From: Jean Tourrilhes To: Thomas Gleixner Cc: Rusty Russell , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kthread: export park/unpark facility Message-ID: <20150709162017.GB24426@hpl.hp.com> Reply-To: jt@hpl.hp.com References: <20150709004020.GA21087@hpl.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: HP Labs Palo Alto Address: HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA. E-mail: jt@hpl.hp.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 09, 2015 at 10:05:02AM +0200, Thomas Gleixner wrote: > > > This patch should definitely help most modules. > > And how exactly would this help modules? Putting kthread to sleep and waking them up later is slightly tricky : http://www.linuxjournal.com/article/8144 The park and unpark API encapsulate this functionality in a pretty nice and clean API, and avoid duplicating this code in various modules. I'm all for sharing the joy ;-) > Thanks, > > tglx Regards, Jean