From: Wolfram Sang <wsa@the-dreams.de>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, punnaia@xilinx.com,
harinik@xilinx.com, anirudh@xilinx.com, svemula@xilinx.com,
Anurag Kumar Vulisha <anuragku@xilinx.com>
Subject: Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC
Date: Thu, 9 Jul 2015 22:09:13 +0200 [thread overview]
Message-ID: <20150709200913.GL4744@katana> (raw)
In-Reply-To: <1434644382-11905-1-git-send-email-anuragku@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
Hi,
thanks for the submission!
> +#define CDNS_I2C_BROKEN_HOLD_BIT 0x00000001
BIT(0) maybe?
> +static const struct cdns_platform_data r1p10_i2c_def = {
> + .quirks = CDNS_I2C_BROKEN_HOLD_BIT, };
Closing '}' should be on seperate line.
And what Mark said.
Other than that, looks okay I'd say.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-09 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 16:19 [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC Anurag Kumar Vulisha
2015-06-25 15:18 ` Mark Rutland
2015-07-09 20:09 ` Wolfram Sang [this message]
2015-07-10 7:29 ` Anurag Kumar Vulisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709200913.GL4744@katana \
--to=wsa@the-dreams.de \
--cc=anirudh@xilinx.com \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=anuragku@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=harinik@xilinx.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=punnaia@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=svemula@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox