Re: [RFC][PATCH 15/24] powerpc: Provide atomic_{or,xor,and}

Benjamin Herrenschmidt
2015-07-09T21:51:39Z

On Thu, 2015-07-09 at 19:29 +0200, Peter Zijlstra wrote:
> Implement atomic logic ops -- atomic_{or,xor,and}.
>
> These will replace the atomic_{set,clear}_mask functions that are
> available on some archs.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> arch/powerpc/include/asm/atomic.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- a/arch/powerpc/include/asm/atomic.h
> +++ b/arch/powerpc/include/asm/atomic.h
> @@ -66,6 +66,9 @@ static __inline__ int atomic_##op##_retu
>
> ATOMIC_OPS(add, add)
> ATOMIC_OPS(sub, subf)
> +ATOMIC_OP(and, and)
> +ATOMIC_OP(or, or)
> +ATOMIC_OP(xor, xor)
>
> #undef ATOMIC_OPS
> #undef ATOMIC_OP_RETURN
> @@ -304,6 +307,9 @@ static __inline__ long atomic64_##op##_r
>
> ATOMIC64_OPS(add, add)
> ATOMIC64_OPS(sub, subf)
> +ATOMIC64_OP(and, and)
> +ATOMIC64_OP(or, or)
> +ATOMIC64_OP(xor, xor)

As long as you are ok that they are non-ordered atomics (no barrier in
them), then

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> #undef ATOMIC64_OPS
> #undef ATOMIC64_OP_RETURN
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/