Re: [RFC][PATCH 04/24] arm64: Provide atomic_{or,xor,and}

Peter Zijlstra
2015-07-15T16:47:34Z

On Wed, Jul 15, 2015 at 05:01:09PM +0100, Will Deacon wrote:
> On Thu, Jul 09, 2015 at 06:28:59PM +0100, Peter Zijlstra wrote:
> > Implement atomic logic ops -- atomic_{or,xor,and}.
> >
> > These will replace the atomic_{set,clear}_mask functions that are
> > available on some archs.
> >
> >
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > ---
> > arch/arm64/include/asm/atomic.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > --- a/arch/arm64/include/asm/atomic.h
> > +++ b/arch/arm64/include/asm/atomic.h
> > @@ -84,6 +84,9 @@ static inline int atomic_##op##_return(i
> >
> > ATOMIC_OPS(add, add)
> > ATOMIC_OPS(sub, sub)
> > +ATOMIC_OP(and, and)
> > +ATOMIC_OP(or, orr)
>
> FYI, but without selecting CONFIG_ARCH_HAS_ATOMIC_OR this change leads to
> build errors:

Yah, already ran into that; I've a new set cooking which fixes all these
issues. I get the interesting build fails after a day or so (from the
build-bot).

I just pushed a fresh set into it and was hoping to be able to post
tomorrow.