From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
Austin S Hemmelgarn <ahferroin7@gmail.com>,
Brian Gerst <brgerst@gmail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT
Date: Fri, 10 Jul 2015 10:45:16 +0200 [thread overview]
Message-ID: <20150710084516.GA15959@gmail.com> (raw)
In-Reply-To: <CA+55aFzdBf4GPyR-+FRy3PkBdvp0f7PJ1xCx6SSUU=WN=PvUzw@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> [...]
>
> The one thing we might want to do is to rename the config option, simply to make
> sure that people who do "make oldconfig" will actually see the new question and
> hopefully pick the new default rather than just getting their old "y" without
> even seeing it. Call the option "LEGACY_VM86" or something, perhaps?
Absolutely!
The 'default n' makes very little sense without changing the name - most distros
have the old symbol already and will just grandfather in at whatever value it was.
Change the name and also update the help text to make it scarier: point out that
it has known quirks and that we don't really trust the code because it's ancient,
crippled on the hardware side because vm86 mode was never fully documented by CPU
makers, back when x86 CPU makers (and Microsoft) considered virtualization an
enemy of Windows revenue.
Thanks,
Ingo
next prev parent reply other threads:[~2015-07-10 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 18:40 [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT Andy Lutomirski
2015-07-09 18:43 ` Kees Cook
2015-07-09 18:51 ` Arjan van de Ven
2015-07-09 19:00 ` Andy Lutomirski
2015-07-09 19:20 ` Linus Torvalds
2015-07-09 19:42 ` John Stoffel
2015-07-10 13:41 ` Pavel Machek
2015-07-10 8:45 ` Ingo Molnar [this message]
2015-07-09 19:27 ` Yuhong Bao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710084516.GA15959@gmail.com \
--to=mingo@kernel.org \
--cc=ahferroin7@gmail.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).