From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: Minfei Huang <mnfhuang@gmail.com>,
ebiederm@xmission.com, vgoyal@redhat.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kexec: Make a pair of map and unmap reserved pages when kdump fails to start
Date: Fri, 10 Jul 2015 11:29:13 +0200 [thread overview]
Message-ID: <20150710112913.3d6853cb@holzheu> (raw)
In-Reply-To: <20150710111406.279dba14@holzheu>
On Fri, 10 Jul 2015 11:14:06 +0200
Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> On Fri, 10 Jul 2015 17:03:22 +0800
> Minfei Huang <mnfhuang@gmail.com> wrote:
[snip]
> +static int __kexec_load(unsigned long entry, unsigned long nr_segments,
> + struct kexec_segment __user *segments,
> + unsigned long flags)
> +{
> + struct kimage **dest_image, *image;
> + unsigned long i;
> + int result;
> +
> + if (flags & KEXEC_ON_CRASH)
> + dest_image = &kexec_crash_image;
> + else
> + dest_image = &kexec_image;
> +
> + if (nr_segments == 0) {
> + /* Uninstall image */
> + kfree(xchg(dest_image, NULL));
Sorry, too fast today...
Should be of course not kfree, but:
kimage_free(dest_image, NULL));
Michael
next prev parent reply other threads:[~2015-07-10 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 5:12 [PATCH v4] kexec: Make a pair of map and unmap reserved pages when kdump fails to start Minfei Huang
2015-07-10 8:54 ` Michael Holzheu
2015-07-10 9:03 ` Minfei Huang
2015-07-10 9:14 ` Michael Holzheu
2015-07-10 9:29 ` Michael Holzheu [this message]
2015-07-14 14:09 ` Vivek Goyal
2015-07-14 18:10 ` Michael Holzheu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710112913.3d6853cb@holzheu \
--to=holzheu@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mnfhuang@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox