From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754669AbbGJL53 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jul 2015 07:57:29 -0400
Received: from e28smtp09.in.ibm.com ([122.248.162.9]:59916 "EHLO
	e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754105AbbGJL5V (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jul 2015 07:57:21 -0400
X-Helo: d28dlp02.in.ibm.com
X-MailFrom: srikar@linux.vnet.ibm.com
X-RcptTo: linux-kernel@vger.kernel.org
Date: Fri, 10 Jul 2015 17:27:05 +0530
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ananth Mavinakayanahalli <ananth@in.ibm.com>,
        Anton Arapov <arapov@gmail.com>, David Long <dave.long@linaro.org>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        "Frank Ch. Eigler" <fche@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Jan Willeke <willeke@de.ibm.com>, Jim Keniston <jkenisto@us.ibm.com>,
        Mark Wielaard <mjw@redhat.com>, Pratyush Anand <panand@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/11] uprobes: Change prepare_uretprobe() to (try to)
 flush the dead frames
Message-ID: <20150710115704.GI26095@linux.vnet.ibm.com>
Reply-To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
References: <20150707012210.GA7466@redhat.com>
 <20150707012306.GA7543@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20150707012306.GA7543@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 15071011-0033-0000-0000-000006AF17EC
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Oleg Nesterov <oleg@redhat.com> [2015-07-07 03:23:06]:

> Change prepare_uretprobe() to flush the !arch_uretprobe_is_alive()
> return_instance's. This is not needed correctness-wise, but can help
> to avoid the failure caused by MAX_URETPROBE_DEPTH.
> 
> Note: in this case arch_uretprobe_is_alive() can be false positive,
> the stack can grow after longjmp(). Unfortunately, the kernel can't
> 100% solve this problem, but see the next patch.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Looks good to me.

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

-- 
Thanks and Regards
Srikar Dronamraju