From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>
Subject: [patch 8/9] mfd/ucb1x00: Prepare ucb1x00_irq for irq argument removal
Date: Mon, 13 Jul 2015 20:44:57 -0000 [thread overview]
Message-ID: <20150712225930.074652157@linutronix.de> (raw)
In-Reply-To: 20150712225758.573960291@linutronix.de
[-- Attachment #1: mfd-ucb1x00-prepare-ucb1x00_irq-for-irq-argument-removal.patch --]
[-- Type: text/plain, Size: 1376 bytes --]
irq is incremented for no value in the for loop. Remove it.
Search and update was done with coccinelle and the invaluable help of
Julia Lawall.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/ucb1x00-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: tip/drivers/mfd/ucb1x00-core.c
===================================================================
--- tip.orig/drivers/mfd/ucb1x00-core.c
+++ tip/drivers/mfd/ucb1x00-core.c
@@ -282,7 +282,7 @@ void ucb1x00_adc_disable(struct ucb1x00
* SIBCLK to talk to the chip. We leave the clock running until
* we have finished processing all interrupts from the chip.
*/
-static void ucb1x00_irq(unsigned int irq, struct irq_desc *desc)
+static void ucb1x00_irq(unsigned int __irq, struct irq_desc *desc)
{
struct ucb1x00 *ucb = irq_desc_get_handler_data(desc);
unsigned int isr, i;
@@ -292,7 +292,7 @@ static void ucb1x00_irq(unsigned int irq
ucb1x00_reg_write(ucb, UCB_IE_CLEAR, isr);
ucb1x00_reg_write(ucb, UCB_IE_CLEAR, 0);
- for (i = 0; i < 16 && isr; i++, isr >>= 1, irq++)
+ for (i = 0; i < 16 && isr; i++, isr >>= 1)
if (isr & 1)
generic_handle_irq(ucb->irq_base + i);
ucb1x00_disable(ucb);
next prev parent reply other threads:[~2015-07-13 20:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 20:44 [patch 0/9] mfd: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:44 ` [patch 1/9] mfd/ezx-pcap: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-27 15:56 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:04 ` [patch 1/9] " Lee Jones
2015-07-13 20:44 ` [patch 2/9] mfd/htc-egpio: " Thomas Gleixner
2015-07-27 15:56 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:04 ` [patch 2/9] " Lee Jones
2015-07-13 20:44 ` [patch 3/9] mfd/jz4740: " Thomas Gleixner
2015-07-27 15:57 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:04 ` [patch 3/9] " Lee Jones
2015-07-13 20:44 ` [patch 4/9] mfd/pm8921: " Thomas Gleixner
2015-07-27 15:57 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:05 ` [patch 4/9] " Lee Jones
2015-07-13 20:44 ` [patch 5/9] mfd/t7l66xb: " Thomas Gleixner
2015-07-27 15:57 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:05 ` [patch 5/9] " Lee Jones
2015-07-13 20:44 ` [patch 6/9] mfd/tc6393xb: " Thomas Gleixner
2015-07-27 15:58 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:05 ` [patch 6/9] " Lee Jones
2015-07-13 20:44 ` [patch 7/9] mfd: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-27 15:58 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-28 8:05 ` [patch 7/9] " Lee Jones
2015-07-13 20:44 ` Thomas Gleixner [this message]
2015-07-27 15:58 ` [tip:irq/core] mfd/ucb1x00: Prepare ucb1x00_irq for irq argument removal tip-bot for Thomas Gleixner
2015-07-28 8:06 ` [patch 8/9] " Lee Jones
2015-07-13 20:44 ` [patch 9/9] mfd/max899x: Avoid redundant irq_data lookup Thomas Gleixner
2015-07-27 15:59 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:06 ` [patch 9/9] " Lee Jones
2015-07-27 16:20 ` [patch 0/9] mfd: Interrupt cleanups and API change preparation Lee Jones
2015-07-28 8:17 ` Lee Jones
2015-07-28 8:42 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150712225930.074652157@linutronix.de \
--to=tglx@linutronix.de \
--cc=Julia.Lawall@lip6.fr \
--cc=jiang.liu@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox