From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751493AbbGMGdp (ORCPT ); Mon, 13 Jul 2015 02:33:45 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:51455 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbbGMGdo (ORCPT ); Mon, 13 Jul 2015 02:33:44 -0400 Date: Sun, 12 Jul 2015 23:33:41 -0700 From: Christoph Hellwig To: Sergey Senozhatsky Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile Message-ID: <20150713063341.GA24167@infradead.org> References: <1436583115-6323-1-git-send-email-sergey.senozhatsky@gmail.com> <20150711100232.GA4607@infradead.org> <20150712024732.GA787@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150712024732.GA787@swordfish> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 12, 2015 at 11:47:32AM +0900, Sergey Senozhatsky wrote: > Yes, but the main difference here is that it seems that shrinker users > don't tend to treat shrinker registration failures as fatal errors and > just continue with shrinker functionality disabled. And it makes sense. > > (copy paste from https://lkml.org/lkml/2015/7/9/751) > I hearily disagree. It's not any less critical than other failures. The right way forward is to handle register failure properly.