* [PATCH] Staging: android: ion: Fix Style Issue
@ 2015-07-13 17:29 Craig
2015-07-13 11:42 ` Joe Perches
2015-07-13 12:35 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Craig @ 2015-07-13 17:29 UTC (permalink / raw)
To: gregkh; +Cc: arve, riandrews, mitchelh, devel, linux-kernel, Craig
Modified style issue in ion.c. Missing empty line after a definition
Signed-off-by: Craig <craig.inches@xayto.net>
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
struct ion_buffer *buffer;
struct dma_buf *dmabuf;
bool valid_handle;
+
DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
mutex_lock(&client->lock);
--
2.3.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: android: ion: Fix Style Issue
2015-07-13 17:29 [PATCH] Staging: android: ion: Fix Style Issue Craig
@ 2015-07-13 11:42 ` Joe Perches
2015-07-14 9:36 ` Craig Inches
2015-07-13 12:35 ` Dan Carpenter
1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2015-07-13 11:42 UTC (permalink / raw)
To: Craig; +Cc: gregkh, arve, riandrews, mitchelh, devel, linux-kernel
On Mon, 2015-07-13 at 17:29 +0000, Craig wrote:
> Modified style issue in ion.c. Missing empty line after a definition
>
> Signed-off-by: Craig <craig.inches@xayto.net>
> ---
> drivers/staging/android/ion/ion.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> struct ion_buffer *buffer;
> struct dma_buf *dmabuf;
> bool valid_handle;
> +
> DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>
> mutex_lock(&client->lock);
checkpatch false positive.
Fixed in checkpatch by
https://lkml.org/lkml/2015/7/1/383
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: android: ion: Fix Style Issue
2015-07-13 11:42 ` Joe Perches
@ 2015-07-14 9:36 ` Craig Inches
0 siblings, 0 replies; 4+ messages in thread
From: Craig Inches @ 2015-07-14 9:36 UTC (permalink / raw)
To: Joe Perches; +Cc: Craig, gregkh, arve, riandrews, mitchelh, devel, linux-kernel
On Mon, Jul 13, 2015 at 04:42:22AM -0700, Joe Perches wrote:
> On Mon, 2015-07-13 at 17:29 +0000, Craig wrote:
> > Modified style issue in ion.c. Missing empty line after a definition
> >
> > Signed-off-by: Craig <craig.inches@xayto.net>
> > ---
> > drivers/staging/android/ion/ion.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> > index 6f48112..e44f5e6 100644
> > --- a/drivers/staging/android/ion/ion.c
> > +++ b/drivers/staging/android/ion/ion.c
> > @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> > struct ion_buffer *buffer;
> > struct dma_buf *dmabuf;
> > bool valid_handle;
> > +
> > DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
> >
> > mutex_lock(&client->lock);
>
> checkpatch false positive.
Thanks for the feed back.
> Fixed in checkpatch by
> https://lkml.org/lkml/2015/7/1/383
and the reference to the fix.
Cheers,
Craig
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: android: ion: Fix Style Issue
2015-07-13 17:29 [PATCH] Staging: android: ion: Fix Style Issue Craig
2015-07-13 11:42 ` Joe Perches
@ 2015-07-13 12:35 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-07-13 12:35 UTC (permalink / raw)
To: Craig; +Cc: gregkh, devel, riandrews, linux-kernel, arve
Nope. It is a false postive. Also use your full/legal name.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-14 2:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 17:29 [PATCH] Staging: android: ion: Fix Style Issue Craig
2015-07-13 11:42 ` Joe Perches
2015-07-14 9:36 ` Craig Inches
2015-07-13 12:35 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox