public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: android: ion: reorder variable definitions
@ 2015-07-13 12:50 Dmitry Kalinkin
  2015-07-13 13:32 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Kalinkin @ 2015-07-13 12:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Arve Hjønnevåg, Riley Andrews,
	devel, linux-kernel
  Cc: Dmitry Kalinkin

Prevents false positive "missing empty line after a definition"
checkpatch warning.

Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
---
 drivers/staging/android/ion/ion.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..6c922c7 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1103,10 +1103,10 @@ static struct dma_buf_ops dma_buf_ops = {
 struct dma_buf *ion_share_dma_buf(struct ion_client *client,
 						struct ion_handle *handle)
 {
+	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
 	struct ion_buffer *buffer;
 	struct dma_buf *dmabuf;
 	bool valid_handle;
-	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
 
 	mutex_lock(&client->lock);
 	valid_handle = ion_handle_validate(client, handle);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: android: ion: reorder variable definitions
  2015-07-13 12:50 [PATCH] staging: android: ion: reorder variable definitions Dmitry Kalinkin
@ 2015-07-13 13:32 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-07-13 13:32 UTC (permalink / raw)
  To: Dmitry Kalinkin
  Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Riley Andrews,
	devel, linux-kernel

On Mon, Jul 13, 2015 at 03:50:30PM +0300, Dmitry Kalinkin wrote:
> Prevents false positive "missing empty line after a definition"
> checkpatch warning.
> 
> Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
> ---

Clap clap clap.  :)

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-13 13:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 12:50 [PATCH] staging: android: ion: reorder variable definitions Dmitry Kalinkin
2015-07-13 13:32 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox