From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>
Subject: [patch 2/5] sh/irq: Use irq accessor functions instead of open coded access
Date: Mon, 13 Jul 2015 20:51:22 -0000 [thread overview]
Message-ID: <20150713151626.616384365@linutronix.de> (raw)
In-Reply-To: 20150713151529.858862519@linutronix.de
[-- Attachment #1: sh-irq-Use-accessor-functions-to-irq_data.patch --]
[-- Type: text/plain, Size: 1389 bytes --]
From: Jiang Liu <jiang.liu@linux.intel.com>
This is a preparatory patch for refactoring the internals if irq_data.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>
Link: http://lkml.kernel.org/r/1433145945-789-12-git-send-email-jiang.liu@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/sh/intc/virq.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
Index: tip/drivers/sh/intc/virq.c
===================================================================
--- tip.orig/drivers/sh/intc/virq.c
+++ tip/drivers/sh/intc/virq.c
@@ -83,12 +83,11 @@ EXPORT_SYMBOL_GPL(intc_irq_lookup);
static int add_virq_to_pirq(unsigned int irq, unsigned int virq)
{
- struct intc_virq_list **last, *entry;
- struct irq_data *data = irq_get_irq_data(irq);
+ struct intc_virq_list *entry;
+ struct intc_virq_list **last = NULL;
/* scan for duplicates */
- last = (struct intc_virq_list **)&data->handler_data;
- for_each_virq(entry, data->handler_data) {
+ for_each_virq(entry, irq_get_handler_data(irq)) {
if (entry->irq == virq)
return 0;
last = &entry->next;
@@ -102,7 +101,10 @@ static int add_virq_to_pirq(unsigned int
entry->irq = virq;
- *last = entry;
+ if (last)
+ *last = entry;
+ else
+ irq_set_handler_data(irq, entry);
return 0;
}
next prev parent reply other threads:[~2015-07-13 20:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 20:51 [patch 0/5] sh: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:51 ` [patch 1/5] sh/irq: Use accessor irq_data_get_node() Thomas Gleixner
2015-07-27 15:59 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-29 8:16 ` tip-bot for Jiang Liu
2015-07-13 20:51 ` Thomas Gleixner [this message]
2015-07-27 15:59 ` [tip:irq/core] sh/irq: Use irq accessor functions instead of open coded access tip-bot for Jiang Liu
2015-07-29 8:16 ` tip-bot for Jiang Liu
2015-07-13 20:51 ` [patch 3/5] sh/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner
2015-07-27 15:59 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-29 8:16 ` tip-bot for Thomas Gleixner
2015-07-13 20:51 ` [patch 4/5] sh/intc: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-27 16:00 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-29 8:17 ` tip-bot for Jiang Liu
2015-07-13 20:51 ` [patch 5/5] sh/intc: Prepare irq flow handlers for irq argument removal Thomas Gleixner
2015-07-27 16:00 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-29 8:17 ` tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713151626.616384365@linutronix.de \
--to=tglx@linutronix.de \
--cc=horms@verge.net.au \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox