From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbbGMV1g (ORCPT ); Mon, 13 Jul 2015 17:27:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50789 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbbGMV1d (ORCPT ); Mon, 13 Jul 2015 17:27:33 -0400 Date: Mon, 13 Jul 2015 23:25:52 +0200 From: Oleg Nesterov To: Al Viro , Jan Kara , Linus Torvalds , Paul McKenney , Peter Zijlstra Cc: Daniel Wagner , Davidlohr Bueso , Ingo Molnar , Tejun Heo , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] introduce sb_unlock_frozen() Message-ID: <20150713212552.GA13876@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150713212536.GA13855@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Preaparation. Add the trivial helper which does the wakeup. --- fs/super.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/super.c b/fs/super.c index 5ea0edd..c23bafc 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1254,6 +1254,12 @@ static void sb_wait_write(struct super_block *sb, int level) } while (writers); } +static void sb_unlock_frozen(struct super_block *sb) +{ + smp_wmb(); + wake_up(&sb->s_writers.wait_unfrozen); +} + /** * freeze_super - lock the filesystem and force it into a consistent state * @sb: the super to lock @@ -1340,8 +1346,7 @@ int freeze_super(struct super_block *sb) printk(KERN_ERR "VFS:Filesystem freeze failed\n"); sb->s_writers.frozen = SB_UNFROZEN; - smp_wmb(); - wake_up(&sb->s_writers.wait_unfrozen); + sb_unlock_frozen(sb); deactivate_locked_super(sb); return ret; } @@ -1387,8 +1392,7 @@ int thaw_super(struct super_block *sb) out: sb->s_writers.frozen = SB_UNFROZEN; - smp_wmb(); - wake_up(&sb->s_writers.wait_unfrozen); + sb_unlock_frozen(sb); deactivate_locked_super(sb); return 0; -- 1.5.5.1