From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbbGNF54 (ORCPT ); Tue, 14 Jul 2015 01:57:56 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:35100 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbbGNF5z (ORCPT ); Tue, 14 Jul 2015 01:57:55 -0400 Date: Tue, 14 Jul 2015 11:26:07 +0530 From: Sudip Mukherjee To: Henri Chain Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, noralf@tronnes.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller Message-ID: <20150714055607.GA18815@sudip-PC> References: <1436837172-8155-1-git-send-email-henri.chain@eleves.ec-nantes.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436837172-8155-1-git-send-email-henri.chain@eleves.ec-nantes.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2015 at 03:26:12AM +0200, Henri Chain wrote: > This is a driver chip for 240x160 4-bit greyscale LCDs. > It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been > tested. (It also has a 6800 or 8080-style parallel interface, but I have > not included support for it.) > > Signed-off-by: Henri Chain > --- > +} > + > +static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) > +{ > + fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, > + "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye); checkpatch complains: Alignment should match open parenthesis. regards sudip