From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
Jes.Sorensen@redhat.com, sparmaintainer@unisys.com,
driverdev-devel@linuxdriverproject.org,
Tim Sell <Timothy.Sell@unisys.com>
Subject: [patch] checkpatch: Fixes: tag lines are allowed to be long
Date: Tue, 14 Jul 2015 14:07:36 +0300 [thread overview]
Message-ID: <20150714110736.GA10856@mwanda> (raw)
A lot of the Fixes: tags go over the 75 character limit and that's ok.
Fixes: 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
The other common cause of false positives it Oops output but I don't
have an idea how to filter for that.
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 90e1edc..537973b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2310,7 +2310,7 @@ sub process {
# Check for line lengths > 75 in commit log, warn once
if ($in_commit_log && !$commit_log_long_line &&
- length($line) > 75) {
+ length($line) > 75 && !($line =~ /^Fixes:/)) {
WARN("COMMIT_LOG_LONG_LINE",
"Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
$commit_log_long_line = 1;
next reply other threads:[~2015-07-14 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 11:07 Dan Carpenter [this message]
2015-07-15 4:11 ` [patch] checkpatch: Fixes: tag lines are allowed to be long Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714110736.GA10856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Timothy.Sell@unisys.com \
--cc=apw@canonical.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox