From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: linux-kernel@vger.kernel.org, snitzer@redhat.com, hch@lst.de
Subject: Re: [PATCH 0/2] Configurable max discard size
Date: Tue, 14 Jul 2015 18:01:47 +0200 [thread overview]
Message-ID: <20150714160147.GA28031@lst.de> (raw)
In-Reply-To: <1436886139-18673-1-git-send-email-axboe@fb.com>
On Tue, Jul 14, 2015 at 09:02:17AM -0600, Jens Axboe wrote:
> Hi,
>
> Most drivers use UINT_MAX (or some variant thereof) for max discard
> size, since they don't have a real limit for a non-data transferring
> command. This is fine from a throughput point of view, but for a lot
> of devices (all?), it truly sucks on latency. We've seen cases of
> hundreds of msec in latencies for reads/writes when deleting files
> on an fs with discard enabled. For the problematic devices that we
> have tested, artificially limiting the size of the discards issued
> brings it down to a more manageable 1-2ms max latencies.
This looks reasonable to me. Any chance you could also come up
with reasonable start values for the hardware you've done this for
so that we can get a good out of the box experience?
next prev parent reply other threads:[~2015-07-14 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 15:02 [PATCH 0/2] Configurable max discard size Jens Axboe
2015-07-14 15:02 ` [PATCH 1/2] block: have drivers use blk_queue_max_discard_sectors() Jens Axboe
2015-07-14 15:02 ` [PATCH 2/2] block: make /sys/block/<dev>/queue/discard_max_bytes writeable Jens Axboe
2015-07-14 15:23 ` Mike Snitzer
2015-07-14 15:29 ` Jens Axboe
2015-07-14 16:01 ` Christoph Hellwig [this message]
2015-07-14 16:04 ` [PATCH 0/2] Configurable max discard size Jens Axboe
2015-07-14 17:53 ` Christoph Hellwig
2015-07-14 18:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714160147.GA28031@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox