From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Dongsheng Wang <dongsheng.wang@freescale.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
Date: Wed, 15 Jul 2015 00:50:41 +0200 [thread overview]
Message-ID: <20150714225041.GH20482@piout.net> (raw)
In-Reply-To: <1436249576-23233-1-git-send-email-dongsheng.wang@freescale.com>
Hi,
This seems ok, one small nitpick:
On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
> diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c
> index 7e48e53..2081155 100644
> --- a/drivers/rtc/rtc-ds3232.c
> +++ b/drivers/rtc/rtc-ds3232.c
> @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
>
> if (device_can_wakeup(dev)) {
> ds3232->suspended = true;
> - irq_set_irq_wake(client->irq, 1);
> + if (irq_set_irq_wake(client->irq, 1)) {
> + dev_info(dev, "Cannot serve as a wakeup source\n");
I would use dev_warn_once or dev_info_once here to avoid spamming the
log each time the machine is suspended.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-14 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 6:12 [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function Dongsheng Wang
2015-07-14 22:50 ` Alexandre Belloni [this message]
2015-07-15 2:06 ` Wang Dongsheng
2015-08-12 7:50 ` Wang Dongsheng
2015-08-12 8:10 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714225041.GH20482@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=dongsheng.wang@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox