From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753632AbbGNWup (ORCPT ); Tue, 14 Jul 2015 18:50:45 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56542 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753597AbbGNWun (ORCPT ); Tue, 14 Jul 2015 18:50:43 -0400 Date: Wed, 15 Jul 2015 00:50:41 +0200 From: Alexandre Belloni To: Dongsheng Wang Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function Message-ID: <20150714225041.GH20482@piout.net> References: <1436249576-23233-1-git-send-email-dongsheng.wang@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436249576-23233-1-git-send-email-dongsheng.wang@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This seems ok, one small nitpick: On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote : > From: Wang Dongsheng > diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c > index 7e48e53..2081155 100644 > --- a/drivers/rtc/rtc-ds3232.c > +++ b/drivers/rtc/rtc-ds3232.c > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev) > > if (device_can_wakeup(dev)) { > ds3232->suspended = true; > - irq_set_irq_wake(client->irq, 1); > + if (irq_set_irq_wake(client->irq, 1)) { > + dev_info(dev, "Cannot serve as a wakeup source\n"); I would use dev_warn_once or dev_info_once here to avoid spamming the log each time the machine is suspended. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com