* [PATCH][RESEND] rts5208:Fix checkpatch warnings
@ 2015-07-01 6:57 Ravi Teja Darbha
2015-07-15 3:18 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ravi Teja Darbha @ 2015-07-01 6:57 UTC (permalink / raw)
To: gregkh; +Cc: joe, fabio.falzoi84, nizamhaider786, devel, linux-kernel
else is not generally useful after a break or return, hence removed.
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
---
drivers/staging/rts5208/xd.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 10fea7b..42d8d82 100644
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -1689,10 +1689,9 @@ static int xd_read_multiple_pages(struct rtsx_chip *chip, u32 phy_blk,
xd_set_err_code(chip, XD_TO_ERROR);
rtsx_trace(chip);
return STATUS_FAIL;
- } else {
- rtsx_trace(chip);
- goto Fail;
}
+ rtsx_trace(chip);
+ goto Fail;
}
return STATUS_SUCCESS;
@@ -1905,10 +1904,9 @@ static int xd_write_multiple_pages(struct rtsx_chip *chip, u32 old_blk,
xd_set_err_code(chip, XD_TO_ERROR);
rtsx_trace(chip);
return STATUS_FAIL;
- } else {
- rtsx_trace(chip);
- goto Fail;
}
+ rtsx_trace(chip);
+ goto Fail;
}
if (end_page == (xd_card->page_off + 1)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][RESEND] rts5208:Fix checkpatch warnings
2015-07-01 6:57 [PATCH][RESEND] rts5208:Fix checkpatch warnings Ravi Teja Darbha
@ 2015-07-15 3:18 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-07-15 3:18 UTC (permalink / raw)
To: Ravi Teja Darbha; +Cc: joe, devel, nizamhaider786, fabio.falzoi84, linux-kernel
On Wed, Jul 01, 2015 at 12:27:38PM +0530, Ravi Teja Darbha wrote:
> else is not generally useful after a break or return, hence removed.
>
> Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
> ---
> drivers/staging/rts5208/xd.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Why resend? What is different from the previous version? What was
wrong with it?
Please be specific when sending patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-15 3:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 6:57 [PATCH][RESEND] rts5208:Fix checkpatch warnings Ravi Teja Darbha
2015-07-15 3:18 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox