From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751940AbbGOErI (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jul 2015 00:47:08 -0400
Received: from mail-pd0-f169.google.com ([209.85.192.169]:33611 "EHLO
	mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751022AbbGOErH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jul 2015 00:47:07 -0400
Date: Wed, 15 Jul 2015 10:16:56 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 4/5] staging: sm7xxfb: define new macros
Message-ID: <20150715044655.GA17865@sudip-PC>
References: <1436256877-10754-1-git-send-email-sudipm.mukherjee@gmail.com>
 <1436256877-10754-5-git-send-email-sudipm.mukherjee@gmail.com>
 <20150715030508.GA20352@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150715030508.GA20352@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 14, 2015 at 08:05:08PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote:
> > +#define mmio_addr		0x00c00000
> > +#define seqw17
> 
> Odd, empty macros are not good, because:
> 
> > -#ifdef __BIG_ENDIAN
> >  		if (sfb->fb->var.bits_per_pixel == 32)
> > -			smtc_seqw(0x17, 0x30);
> > -#endif
> > +			seqw17;
> 
> That just looks wrong :(
I think it will look better in c file if I make it as
#define seqw17()
I will respin the patches and send.

regards
sudip