From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbbGOMsu (ORCPT ); Wed, 15 Jul 2015 08:48:50 -0400 Received: from mail-bl2on0135.outbound.protection.outlook.com ([65.55.169.135]:17824 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751032AbbGOMsW (ORCPT ); Wed, 15 Jul 2015 08:48:22 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Date: Wed, 15 Jul 2015 20:25:24 +0800 From: Dong Aisheng To: Michael Turquette CC: Dong Aisheng , , , , , , , , , Subject: Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after Message-ID: <20150715122522.GA30570@shlinux1.ap.freescale.net> References: <1431610143-21853-1-git-send-email-aisheng.dong@freescale.com> <1431610143-21853-2-git-send-email-aisheng.dong@freescale.com> <20150528040919.22384.79189@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150528040919.22384.79189@quantum> User-Agent: Mutt/1.5.20 (2009-06-14) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11OLC002;1:KxOc9jRZcvt04KTQXL5uatd8x7wZ9Ik1je8GFCI4BNc8cFMbYXpO2QzTZCfgOkb4nI6RWGI5GbM8s3kdlHAItIMKW2zP8B/5vR9Qj4XlgMmyy9BfszkuLzNQ6z69bp4vOlcAlKv3GtIzWMXzWdpozZefzl5urtL+oVbGmXsiCgnSX9L13YGez3K6WwVY7PY4JdMq2Y6tQFiqnDvZW4p/ud/q/J2qzFPr2nksvXtarV2CkfiO+2HBA7XuFb1qYW7V7CT69EiEj2JflhW5Bz7/u0Zb266epT6m4jKa8stN0X8/ZI3qpi9DWmpuQuh+sIhFTpnw3KJS22y/3oMksMhj5PFAI0UDNtK/MfKSTq54aPkym/XAM/yCkEq+wjJeztKOGXiVfIg8+/7bvzcVhXWwEGuJPnYYWyq/Fc4lRSb64wqtuwwjTaoIeTevwfl/xz9/ X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(339900001)(199003)(377424004)(24454002)(189002)(19580395003)(107886002)(4001350100001)(50986999)(105606002)(76176999)(54356999)(97756001)(19580405001)(46406003)(83506001)(33656002)(23726002)(2950100001)(106466001)(92566002)(5003600100002)(6806004)(62966003)(110136002)(77096005)(87936001)(189998001)(104016003)(50466002)(5001960100002)(47776003)(85426001)(5001920100001)(77156002)(46102003)(4001430100001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1419;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1419;2:3hm/LiwPNRa5C0RHlie5Izh3R65sUJ1WhURFy6h2IJIzRxHe5vjylDJufWdEBr/n;3:TQeVoYOzOU1uMdEyrxbFou+DU/XoKL0olHW5L/v058ahfDqGcADcEYiknDEWZyHJ2pm1Q1IIoX8yxQvSU+sjPK0ga6mLWIAfRcgg32XWl0Kf0Nl8Ktqwd6hNy3FkWHoPtcHgGIoWc6n168XWSWvVAKy7mEyqfDe2VPfIT99YQG+NBR0YmdF9jQQqTJn0Q0MtqCbNktLT7IjYyMwQNHfgB5pXfCtuK9/8zwvrkn6BABg=;25:3FZ9CFtKTtlDXem0qWH+6lCuIrOy6AG0vkxtN9vtgpH2V16rTmPIGnvEnsA0FgvEQsWzTVyEwaBAhrEn7n4L+YVw1rTfyVtOxHJR5fKKAseLZVIV663NAVKZ8wdVdwVvtqHaIPkPtV+xW6kGoFX9FPGW5zbzNrtxkc7YRqJVfLnJ5fVbu0gTDPMRQCVuHwGIbR3GxanwEA9AWNoT1eaJGPKKD5L2M7gM2vMsZl+oKoWBK/byXvvgzYbIxjL6VBY4t9r38qIm/OYIjES33bRMhA==;20:jcjdBUxMZ8IluwjpT9vah6TOfHyS+G4T3gkvVR9rnomvvd+xpFiCnrgP6jq2+Qb6V1MtdORFAAqMeEdMEzhlfyZzBxGARqXWu+QXz32nqjnNznXICDCbrCMw/uVe+/wVDPx3QQOa5oaK5zwMAozJ5Bg8ryhFFh58fR+bG29VAjpUO7kp9mjs18iphVfa1vhQ5F6vsAoM7RYDFZ0dnc5oXjRsn8Fc9K8SNmwq4Hwrl3/RMsA3QeqcmQSOUKqWOQvPkwFbO3qVnN57JYE2xSZiWrvgTAbEZK+ayQ4KtuTfR3xnYqYYWvWRMKpVW8sG8V7zz0IRKfzVn7m1yklsHStG2+3yQScNne1SVJ90mLQX95M= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1419;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1372; BY1PR03MB1419: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY1PR03MB1419;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1419; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1419;4:2Fex8QSX492IgAhYupU1bM05k77mH39yzskA2jEbupEQapSuOkQ69/AP3NGOyhn/CDTq9Wdry7I+7RMaPHqJxbiP9VKNMjodYvgfBhhIDRbz3Csphpc7rXvGqmkOYYaL0UC2vtegopzy6KSdVidaWF23fTPT0hHNtaMNQRyUAXDt8/2hl4SCVVEYIs0AMmmBc0//nUnfTO/nDPkSMbPf1X9UG0u5myBAPxtvELbXX1/ELXvjgcdLRU+hI4b3JcrSXXFBh94pmqV+ktNnFG0q8pKzM4d7SHkXLpdIy449ymE= X-Forefront-PRVS: 0638FD5066 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1419;23:TLgP4fnhzCNzK2/fBvjN2zluJk3QiFyShFTfRKO5K?= =?us-ascii?Q?+CSFETXEK5iUT3N0hQfuIe9heamlnpQvlk5ePiEkVQEvmnZPW1WxyjtgQeKv?= =?us-ascii?Q?Rw7iCQFqV5xutTf0p8/Qhk7FZonnSzMeFu7rXtGOGfh4KabtC+y+8c9PYc0n?= =?us-ascii?Q?W+O9Ntu2hP0lMyvoZygNxoAa8H0yZd1/gCsK3h9Wi+AFUX0vY84O3UtDLWS8?= =?us-ascii?Q?lQxSprgq8Zhm9+mlAt3fj8T0BSbKJGTI7r8CKiWfP3pXNgO2JUmXjluS5vil?= =?us-ascii?Q?sTAIlxuippEyvGGtOFfmHrAU+EAs2AXHmmhjSUK62jox3JkSCZ/50HnGnR2x?= =?us-ascii?Q?UjuGo9qTbOB0TK4VQ4Kca5clrXd7q2gpYbZlobMKjNdl4eICxZeqzyVrNeJQ?= =?us-ascii?Q?GlECgYxThzcn7pkvNxXPefHASPKmF/sB3/TDqs7qIpnd/rRATngGVtDfanjg?= =?us-ascii?Q?7g8lz/bkr0KMDuiUYO/5KxEKn4pshHHD1rvEgPmeo1OutjiTVDJMTsshldbO?= =?us-ascii?Q?kdnYaRTO5UMtr1o/9dDJxF2Yzf6u6IlFYrHJwcIXCRSS9Fauku1dwtKb4VOi?= =?us-ascii?Q?Eud3Cr5n6OVGJzTEZjcMnEDGloigUjg6eLzSJHDp0OZlfON00lHeDYJiv8x0?= =?us-ascii?Q?4xEJVxhSW9LswwjL6AjjUdn2M1RZ/9aiVAnL6fO62IjTR1jKFikQQbVrs/EQ?= =?us-ascii?Q?gUuosHhkOw8VBqjg/dA14WZmitha18krUC3jO7T3MgDGsSzRqhq+R6sgqsK5?= =?us-ascii?Q?EP2nqX6AFtfE4uhvZZRz6VwP2VbdWCRztR3rvm6JGtkWdPAKygiQJHxbkHRY?= =?us-ascii?Q?m2Vsa+kc04Qyz/w24PoC93XDuwEKPQI4kU4OuBExFbOGg5TYxxE6//yc38C0?= =?us-ascii?Q?Rxsi9enqX9IQEtMlaU+/RM+z6NIzvMX9cd1o2dzp9bZkfFW+GDEXu7JvOhJ6?= =?us-ascii?Q?grikE7JF2zeTt2NLcQ4X6uZOhqMXIZTfYaAeYTHKPWestKv0fMJ/nS6oPs9n?= =?us-ascii?Q?w7v3TIWH2Kal/yT5OD0NZ4oKz684ManH8voM/a59mVZdvxXMkodsix1DNlOV?= =?us-ascii?Q?rKNaXgsxOdsx5tU1xvjV5T25O5j?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1419;5:nRXLsYbQCAkGEih0yLquoT3/y723hgQQibcr6QrAhQccq3XxlfYSBQ2V6fjdnVKdUMrKg1A78kliZSpjIxjsl56Cqqj83Vub7VtwI7U1PZu71vtSMcBsCR/DFo+dxTy0Z3Q8v/5Zrabg12x2HGs3fg==;24:XyuU6rBpvSK3OUTo1zSdrdU5b+eAFpwmVTBW4LZPAXS/4nUD9fNrgbwXrQ9do9Lwl2eXZopoH2SzwE0B0w/xaH0fqfnDsZNtGrIAb3b7lB0=;20:1IqOudNuSUbQtxfMzpRBmKgyaZoy7Uo6my03+oWCPPz4dBviIbGWGUQugxdEpfvKn7UV2XkGoRg5GFVsedxGlw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2015 12:32:18.5873 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1419 X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1372;2:qqp77Bl0PCJHGyJwjKRfP9LEmKy9KFZCGVICMJF/dDUvMs6LPsueqF+3NoRjNPpM;3:MbcSjiuuDdvu98AYUlcPjyim+4c0C/Yq0B0QKF3EQhEF3krkAjGHj58jmhvYtTx7iO0gjhtLjS1Pu9k/JhrwJTM1Z1gUdoeCxw8W+D3yxbLF0/FPClUwHOLukTpRM8OitFZXgDnv40btmFgvBVICr6PvEHq+nXXu0FNcr+dWTBP4RGaKClDblclFnTroiBq8KMirbVKATlqC/IW7vlCVEt3GglLUMjFTcwU2z2lZHf4=;25:SKBfX4IgNnq7cWevxJYWusuS/anEFxFW9yrXTLDkofr99uYXGfGmL7fKtqNUdMVDGWhWfEjmwCxy2icxpjyBXx9hIFLnru9SKw9NDkWCnbNqj8Erzym6F5223A2w3yJRrUtmSM1/R+jTnB0Ymrrg1M5mQCCprzFpoDHqML1gLeniCpOdbv2Nlqz3AjTXuPldpQzy1669/O18aRF5tGAXMq1QiHMmuEC0stuQxqWh1qxbk10vc4XZ2viCmRSxe24uIpbjuuxTpnDWRdyjaFWofw==;23:aFqaSCX0ZEMHt3v92Y4KVaBU74H12eogATIKNhCXy6ds6J79M/Wg7S+EDKhqmtbX8x/szj9wtfyMeBKx2z+FtaUiTWE6K7xpwWK0YxFq8VUqLMxMdm8Kai14y3emRiiSQ7j68sTypus7sJvwyJTNC7oiwI5JbFXcL67d89aSq6ldJLgDpZL5vLLPAONftIyWz9iTGDj2W2A7QaCAMW970zOUrCCyUZrhhSfkaExS8EM2RP2vwq7Jfwt+mXTESC3Q X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike, On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-05-14 06:28:59) > > __clk_set_parent_after() actually used the second argument then we > > could put this duplicate logic in there and call it with a different > > order of arguments in the success vs. error paths in this function. > > > > Cc: Mike Turquette > > Cc: Stephen Boyd > > Suggested-by: Stephen Boyd > > Signed-off-by: Dong Aisheng > > Patch looks good to me. > > Also just noticed that the second argument to __clk_set_parent_after is > never used :-( > Ping... I did not see this patch series in your tree for v4.2 rc. Is this got missed? Regards Dong Aisheng > Regards, > Mike > > > --- > > drivers/clk/clk.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > index 659f2b0..0e813ea 100644 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -1159,14 +1159,8 @@ static int __clk_set_parent(struct clk_core *core, struct clk_core *parent, > > flags = clk_enable_lock(); > > clk_reparent(core, old_parent); > > clk_enable_unlock(flags); > > + __clk_set_parent_after(core, old_parent, parent); > > > > - if (core->prepare_count) { > > - flags = clk_enable_lock(); > > - clk_core_disable(core); > > - clk_core_disable(parent); > > - clk_enable_unlock(flags); > > - clk_core_unprepare(parent); > > - } > > return ret; > > } > > > > -- > > 1.9.1 > >