From: NeilBrown <neilb@suse.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: NeilBrown <neilb@suse.de>,
"J. Bruce Fields" <bfields@fieldses.org>,
John Stoffel <john@stoffel.org>,
Austin S Hemmelgarn <ahferroin7@gmail.com>,
Kevin Easton <kevin@guarana.org>, "Theodore Ts'o" <tytso@mit.edu>,
Sage Weil <sage@newdream.net>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Dave Chinner <david@fromorbit.com>, Zach Brown <zab@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux API Mailing List <linux-api@vger.kernel.org>
Subject: Re: [PATCH RFC] vfs: add a O_NOMTIME flag
Date: Wed, 15 Jul 2015 14:54:56 +1000 [thread overview]
Message-ID: <20150715145456.0376796b@noble> (raw)
In-Reply-To: <20150714131300.GA6804@amd>
On Tue, 14 Jul 2015 15:13:00 +0200 Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> > BTW When you "swap" to a file the mtime doesn't get updated. No one seems to
> > complain about that. I guess it is a rather narrow use-case though.
>
> Actually yes, I'd like to complain.
>
> It was not swap, it was mount -o loop, but I guess that's the same
> case. Then rsync refused to work on that file... and being on slow ARM
> system it took me a while to figure out WTF is going on.
>
> So yes, we have problems with mtime, and yes, they matter.
> Pavel
Odd...
I assume you mean
mount -o loop /some/file /mountpoint
and then when you write to the filesystem on /mountpoint the mtime
of /some/file doesn't get updated?
I think it should.
drivers/block/loop.c uses vfs_iter_write() to write to a file.
That calls f_op->write_iter which will typically call
generic_file_write_iter() which will call file_update_time() to update
the time stamps.
What filesystem was /some/file on?
I just did some testing on ext4 and it seems to do the right thing
mtime gets updated.
NeilBrown
next prev parent reply other threads:[~2015-07-15 4:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 22:00 [PATCH RFC] vfs: add a O_NOMTIME flag Zach Brown
2015-05-06 22:14 ` Trond Myklebust
2015-05-06 22:19 ` Sage Weil
2015-05-06 22:41 ` Zach Brown
2015-05-06 22:46 ` Sage Weil
2015-05-06 23:21 ` Theodore Ts'o
2015-05-07 0:26 ` Dave Chinner
2015-05-07 17:20 ` Zach Brown
2015-05-07 18:43 ` Zach Brown
2015-05-07 19:09 ` Richard Weinberger
2015-05-07 19:53 ` Andy Lutomirski
[not found] ` <554BC4D8.9010507@nod.at>
2015-05-07 20:06 ` Andy Lutomirski
2015-05-08 2:42 ` Dave Chinner
2015-07-14 11:44 ` Pavel Machek
2015-05-08 1:01 ` Sage Weil
2015-05-08 1:23 ` Trond Myklebust
2015-05-08 15:19 ` Sage Weil
2015-05-08 22:13 ` Dave Chinner
2015-05-08 22:24 ` Sage Weil
2015-05-10 23:13 ` Trond Myklebust
2015-05-11 7:31 ` Dave Chinner
2015-05-11 16:39 ` Sage Weil
2015-05-11 17:12 ` Trond Myklebust
2015-05-11 17:30 ` Sage Weil
2015-05-12 1:21 ` Dave Chinner
2015-05-12 23:12 ` Sage Weil
2015-05-13 0:57 ` Dave Chinner
2015-05-12 13:41 ` John Stoffel
2015-05-11 14:47 ` Theodore Ts'o
2015-05-11 16:24 ` Sage Weil
2015-05-11 23:10 ` Theodore Ts'o
2015-05-12 5:08 ` Kevin Easton
2015-05-12 11:45 ` Austin S Hemmelgarn
2015-05-12 13:54 ` John Stoffel
2015-05-12 14:36 ` J. Bruce Fields
2015-05-12 14:53 ` Austin S Hemmelgarn
2015-05-12 21:51 ` Dave Chinner
2015-05-13 15:16 ` Austin S Hemmelgarn
2015-05-12 22:39 ` NeilBrown
2015-07-14 13:13 ` Pavel Machek
2015-07-15 4:54 ` NeilBrown [this message]
2015-07-22 13:47 ` Pavel Machek
2015-05-12 21:35 ` Sage Weil
2015-05-13 12:32 ` Jan Kara
2015-05-08 14:29 ` John Stoffel
2015-07-14 11:50 ` Pavel Machek
2015-05-08 14:43 ` Austin S Hemmelgarn
2015-05-08 17:11 ` Zach Brown
2015-05-08 2:37 ` Dave Chinner
2015-05-08 3:24 ` Andy Lutomirski
2015-05-08 14:44 ` Eric Sandeen
2015-05-11 20:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715145456.0376796b@noble \
--to=neilb@suse.com \
--cc=ahferroin7@gmail.com \
--cc=bfields@fieldses.org \
--cc=david@fromorbit.com \
--cc=john@stoffel.org \
--cc=kevin@guarana.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=pavel@ucw.cz \
--cc=sage@newdream.net \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox