From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-api@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support
Date: Wed, 15 Jul 2015 18:45:40 +0200 [thread overview]
Message-ID: <20150715164540.GA4047@salvia> (raw)
In-Reply-To: <20150714162850.GA8478@unicorn.suse.cz>
On Tue, Jul 14, 2015 at 06:28:50PM +0200, Michal Kubecek wrote:
> On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote:
> > On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote:
> > > @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = {
> > > .mode = 0644,
> > > .proc_handler = proc_dointvec_jiffies,
> > > },
> > > + {
> > > + .procname = "nf_conntrack_sctp_timeout_heartbeat_sent",
> > > + .maxlen = sizeof(unsigned int),
> > > + .mode = 0644,
> > > + .proc_handler = proc_dointvec_jiffies,
> > > + },
> > > + {
> > > + .procname = "nf_conntrack_sctp_timeout_heartbeat_acked",
> > > + .maxlen = sizeof(unsigned int),
> > > + .mode = 0644,
> > > + .proc_handler = proc_dointvec_jiffies,
> > > + },
> > > { }
> > > };
> > >
> > > @@ -705,6 +755,18 @@ static struct ctl_table sctp_compat_sysctl_table[] = {
> > > .mode = 0644,
> > > .proc_handler = proc_dointvec_jiffies,
> > > },
> > > + {
> > > + .procname = "ip_conntrack_sctp_timeout_heartbeat_sent",
> > > + .maxlen = sizeof(unsigned int),
> > > + .mode = 0644,
> > > + .proc_handler = proc_dointvec_jiffies,
> > > + },
> > > + {
> > > + .procname = "ip_conntrack_sctp_timeout_heartbeat_acked",
> > > + .maxlen = sizeof(unsigned int),
> > > + .mode = 0644,
> > > + .proc_handler = proc_dointvec_jiffies,
> > > + },
> > > { }
> >
> > I don't see the nla_policy updates for the netlink cttimeout
> > interface.
>
> I didn't realize those were needed. It means adding two entries to
> sctp_timeout_nla_policy and two values to enum ctattr_timeout_sctp?
Exactly.
next prev parent reply other threads:[~2015-07-15 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 12:23 [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support Michal Kubecek
2015-07-14 13:42 ` Florian Westphal
2015-07-14 16:42 ` Michal Kubecek
2015-07-15 20:35 ` Marcelo Ricardo Leitner
2015-07-16 12:05 ` Michal Kubecek
2015-07-16 13:18 ` Marcelo Ricardo Leitner
2015-07-14 15:38 ` Pablo Neira Ayuso
2015-07-14 16:28 ` Michal Kubecek
2015-07-15 16:45 ` Pablo Neira Ayuso [this message]
2015-07-16 13:50 ` Marcelo Ricardo Leitner
2015-07-16 16:13 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715164540.GA4047@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox