From: Jean Delvare <jdelvare@suse.de>
To: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: fenghua.yu@intel.com, linux@roeck-us.net,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data
Date: Wed, 15 Jul 2015 23:07:34 +0200 [thread overview]
Message-ID: <20150715230734.76347af2@endymion.delvare> (raw)
In-Reply-To: <1436976253-4810-1-git-send-email-lukasz.odzioba@intel.com>
On Wed, 15 Jul 2015 18:04:13 +0200, Lukasz Odzioba wrote:
> Removes the limits of supported CPU cores and max core ID.
I see the benefit of removing the arbitrary limit, but why use a list
instead of a dynamically allocated array? This is turning a O(1)
algorithm into a O(n) algorithm. I know n isn't too large in this case
but I still consider it bad practice if it can be avoided.
Do you expect core IDs to become arbitrarily large? Significantly
larger than the core count?
You need a better patch description for sure. Saying what the patch
does isn't sufficient, you need to explain why this is needed and why
this is the right way to do it.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-07-15 21:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 16:04 [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data Lukasz Odzioba
2015-07-15 21:07 ` Jean Delvare [this message]
2015-07-16 13:17 ` Odzioba, Lukasz
2015-07-17 16:55 ` Guenter Roeck
2015-07-17 17:28 ` Odzioba, Lukasz
2015-07-17 18:01 ` Guenter Roeck
2015-07-17 19:23 ` Odzioba, Lukasz
2015-07-17 21:33 ` Jean Delvare
2015-07-17 19:11 ` Jean Delvare
2015-07-17 19:36 ` Guenter Roeck
2015-07-17 21:25 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2012-05-01 21:25 [PATCH] hwmon: coretemp: fix oops on cpu unplug Guenter Roeck
2012-05-02 15:10 ` [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715230734.76347af2@endymion.delvare \
--to=jdelvare@suse.de \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=lukasz.odzioba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox