From: Minchan Kim <minchan@kernel.org>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 1/2] mm/page_owner: fix possible access violation
Date: Thu, 16 Jul 2015 08:53:35 +0900 [thread overview]
Message-ID: <20150715235335.GD988@bgram> (raw)
In-Reply-To: <1436942039-16897-1-git-send-email-iamjoonsoo.kim@lge.com>
On Wed, Jul 15, 2015 at 03:33:58PM +0900, Joonsoo Kim wrote:
> When I tested my new patches, I found that page pointer which is used
> for setting page_owner information is changed. This is because page
> pointer is used to set new migratetype in loop. After this work,
> page pointer could be out of bound. If this wrong pointer is used for
> page_owner, access violation happens. Below is error message that I got.
>
> [ 6175.025217] BUG: unable to handle kernel paging request at 0000000000b00018
> [ 6175.026400] IP: [<ffffffff81025f30>] save_stack_address+0x30/0x40
> [ 6175.027341] PGD 1af2d067 PUD 166e0067 PMD 0
> [ 6175.028129] Oops: 0002 [#1] SMP
> snip...
> [ 6175.055349] Call Trace:
> [ 6175.055780] [<ffffffff81018c0f>] print_context_stack+0xcf/0x100
> [ 6175.056794] [<ffffffff810f8552>] ? __module_text_address+0x12/0x70
> [ 6175.057848] [<ffffffff810177cf>] dump_trace+0x15f/0x320
> [ 6175.058751] [<ffffffff8106b140>] ? do_flush_tlb_all+0x50/0x50
> [ 6175.059732] [<ffffffff810f5529>] ? smp_call_function_single+0xb9/0x120
> [ 6175.060856] [<ffffffff81025e3f>] save_stack_trace+0x2f/0x50
> [ 6175.061812] [<ffffffff811e3366>] __set_page_owner+0x46/0x70
> [ 6175.062774] [<ffffffff8117bd47>] __isolate_free_page+0x1f7/0x210
> [ 6175.063804] [<ffffffff8117bd81>] split_free_page+0x21/0xb0
> [ 6175.064757] [<ffffffff8119aa82>] isolate_freepages_block+0x1e2/0x410
> [ 6175.065855] [<ffffffff8119b53d>] compaction_alloc+0x22d/0x2d0
> [ 6175.066850] [<ffffffff811d3779>] migrate_pages+0x289/0x8b0
> [ 6175.067798] [<ffffffff8119c16a>] ? isolate_migratepages_block+0x28a/0x6e0
> [ 6175.068960] [<ffffffff8119a000>] ? kmalloc_slab+0xa0/0xa0
> [ 6175.069892] [<ffffffff8119b310>] ? ftrace_raw_event_mm_compaction_deplete_template+0xc0/0xc0
> [ 6175.071327] [<ffffffff8119ce49>] compact_zone+0x409/0x880
> [ 6175.072261] [<ffffffff8119d32d>] compact_zone_order+0x6d/0x90
> [ 6175.073250] [<ffffffff8119d5d0>] try_to_compact_pages+0x110/0x210
> [ 6175.074297] [<ffffffff8176e9e8>] __alloc_pages_direct_compact+0x3d/0xe6
> [ 6175.075427] [<ffffffff8117d42d>] __alloc_pages_nodemask+0x6cd/0x9a0
> [ 6175.076517] [<ffffffff811c2bf1>] alloc_pages_current+0x91/0x100
> [ 6175.077545] [<ffffffff811e7216>] runtest_store+0x296/0xa50
> [ 6175.078497] [<ffffffff813a553c>] ? simple_strtoull+0x2c/0x50
> [ 6175.079465] [<ffffffff812130bd>] simple_attr_write+0xbd/0xe0
> [ 6175.080458] [<ffffffff811eb038>] __vfs_write+0x28/0xf0
> [ 6175.081349] [<ffffffff811edc39>] ? __sb_start_write+0x49/0xf0
> [ 6175.082345] [<ffffffff8130fe25>] ? security_file_permission+0x45/0xd0
> [ 6175.083453] [<ffffffff811eb729>] vfs_write+0xa9/0x1b0
> [ 6175.084334] [<ffffffff811ec4f6>] SyS_write+0x46/0xb0
> [ 6175.085196] [<ffffffff81172803>] ? context_tracking_user_enter+0x13/0x20
> [ 6175.086339] [<ffffffff81024c55>] ? syscall_trace_leave+0xa5/0x120
> [ 6175.087389] [<ffffffff81779472>] system_call_fastpath+0x16/0x75
>
> This patch fixes this error by moving up set_page_owner().
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Minchan Kim <minchan@kernel.org>
-stable material?
next prev parent reply other threads:[~2015-07-15 23:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 6:33 [PATCH 1/2] mm/page_owner: fix possible access violation Joonsoo Kim
2015-07-15 6:33 ` [PATCH 2/2] mm/page_owner: set correct gfp_mask on page_owner Joonsoo Kim
2015-07-16 0:06 ` Minchan Kim
2015-07-20 11:27 ` Vlastimil Babka
2015-07-20 11:54 ` Minchan Kim
2015-07-23 5:21 ` Joonsoo Kim
2015-07-15 23:53 ` Minchan Kim [this message]
2015-07-23 5:11 ` [PATCH 1/2] mm/page_owner: fix possible access violation Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715235335.GD988@bgram \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).