From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbbGPAMj (ORCPT ); Wed, 15 Jul 2015 20:12:39 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:36401 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753847AbbGPAMh (ORCPT ); Wed, 15 Jul 2015 20:12:37 -0400 Date: Thu, 16 Jul 2015 09:13:10 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] zsmalloc: use class->pages_per_zspage Message-ID: <20150716001310.GC3970@swordfish> References: <1437003764-2968-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437003764-2968-1-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/16/15 08:42), Minchan Kim wrote: > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 27b9661c8fa6..154a30e9c8a8 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1711,7 +1711,7 @@ static unsigned long zs_can_compact(struct size_class *class) > obj_wasted /= get_maxobj_per_zspage(class->size, > class->pages_per_zspage); > > - return obj_wasted * get_pages_per_zspage(class->size); > + return obj_wasted * class->pages_per_zspage; > } > > static void __zs_compact(struct zs_pool *pool, struct size_class *class) [resending, not sure that my previous reply was delivered. connectivity problems on my side] plus __zs_compact(): @@ -1761,8 +1761,7 @@ static void __zs_compact(struct zs_pool *pool, struct size_class *class) putback_zspage(pool, class, dst_page); if (putback_zspage(pool, class, src_page) == ZS_EMPTY) - pool->stats.pages_compacted += - get_pages_per_zspage(class->size); + pool->stats.pages_compacted += class->pages_per_zspage; spin_unlock(&class->lock); cond_resched(); spin_lock(&class->lock); -ss