From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: "forest@alittletooquiet.net" <forest@alittletooquiet.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"gclement@baobob.org" <gclement@baobob.org>,
"tvboxspy@gmail.com" <tvboxspy@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"joe@perches.com" <joe@perches.com>,
PANKAJ MISHRA <pankaj.m@samsung.com>
Subject: Re: [RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree_skb
Date: Thu, 16 Jul 2015 11:54:30 +0300 [thread overview]
Message-ID: <20150716085430.GF5784@mwanda> (raw)
In-Reply-To: <686357594.854551437036306449.JavaMail.weblogic@ep2mlwas07d>
On Thu, Jul 16, 2015 at 08:45:06AM +0000, Maninder Singh wrote:
> where we are checking for (pTDInfo->skb), we are using it in above line.
> and it does not look good, thats why we should remove thse checks and i have suggested
> changes.
>
> code snippet:-
> -----------------------
>
> if (pTDInfo->skb_dma && (pTDInfo->skb_dma != pTDInfo->buf_dma))
^^^^^^^^^^^^^^^^
This is allocated after ->skb so if ->skb_dma is non-NULL then ->skb is
also non-NULL.
> dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
> pTDInfo->skb->len, DMA_TO_DEVICE);
Is this a static checker warning? If so then it's a false positive.
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-16 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 8:45 [RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree_skb Maninder Singh
2015-07-16 8:54 ` Dan Carpenter [this message]
2015-07-16 10:08 ` Malcolm Priestley
-- strict thread matches above, loose matches on Subject: below --
2015-07-15 3:22 Maninder Singh
2015-07-16 7:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716085430.GF5784@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gclement@baobob.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox