From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: David Dueck <davidcdueck@googlemail.com>,
linux-kernel@vger.kernel.org, bigeasy@linutronix.de,
nicolas.ferre@atmel.com, ludovic.desroches@atmel.com,
boris.brezillon@free-electrons.com,
maxime.ripard@free-electrons.com, wsteinwender@pcs.com,
antoine.tenart@free-electrons.com, mail@jann.io,
c.emde@osadl.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] at91: use request_irq/free_irq instead of setup_irq/remove_irq
Date: Thu, 16 Jul 2015 17:29:02 +0200 [thread overview]
Message-ID: <20150716152902.GN20482@piout.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1507052341420.3916@nanos>
Hi,
On 05/07/2015 at 23:48:26 +0200, Thomas Gleixner wrote :
> On Fri, 3 Jul 2015, David Dueck wrote:
>
> > This fixes a warning when using RT-Preempt.
>
> That's not a proper explanation for the patch and by all means it
> cannot fix anything because free_irq() is just a different wrapper
> around __free_irq() than remove_irq(). So how on earth fixes that the
> problem at hand?
>
Hum, that is quite simple, the following patch
http://git.kernel.org/cgit/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=227cd21851456fb08e87f5a35e0e51280a9fd439
bitrotted and should be rewritten completely or at least dropped.
For drivers/clocksource/timer-atmel-st.c, the patch is broken since at
least 3.18 as NR_IRQS_LEGACY + AT91_ID_SYS is 17 and the actual irq
allocated by irq_of_parse_and_map is 16.
Since 4.1, AT91_ID_SYS doesn't exist anymore and this is not compiling
at all.
For drivers/clocksource/timer-atmel-pit.c, struct irqaction
at91sam926x_pit_irq is never initialized but then it is used in
setup_irq()/remove_irq(). This basically ends up registering a null
handler for IRQ 0.
I'm preparing a replacement patch. I'd even say that this is probably
something we would want to mainline. Meanwhile, can you drop the
mentioned patch?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-16 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 15:33 [PATCH RFC 1/2] at91: make using irqs for clock handling optional David Dueck
2015-07-03 15:33 ` [PATCH 2/2] at91: use request_irq/free_irq instead of setup_irq/remove_irq David Dueck
2015-07-05 21:48 ` Thomas Gleixner
2015-07-16 15:29 ` Alexandre Belloni [this message]
2015-07-05 21:50 ` [PATCH RFC 1/2] at91: make using irqs for clock handling optional Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716152902.GN20482@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=bigeasy@linutronix.de \
--cc=boris.brezillon@free-electrons.com \
--cc=c.emde@osadl.org \
--cc=davidcdueck@googlemail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=mail@jann.io \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=tglx@linutronix.de \
--cc=wsteinwender@pcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox