From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932203AbbGPPp3 (ORCPT ); Thu, 16 Jul 2015 11:45:29 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:36855 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbbGPPp2 (ORCPT ); Thu, 16 Jul 2015 11:45:28 -0400 Date: Thu, 16 Jul 2015 16:45:25 +0100 From: Nariman Poushin To: Mark Brown Cc: oder_chiou@realtek.com, brian.austin@cirrus.com, laurent.pinchart+renesas@ideasonboard.com, sameo@linux.intel.com, alsa-devel@alsa-project.org, airlied@linux.ie, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, dmitry.torokhov@gmail.com, lgirdwood@gmail.com, Paul.Handrigan@cirrus.com, linux-kernel@vger.kernel.org, peter.ujfalusi@ti.com, tony@atomide.com, lars@metafoo.de, dmurphy@ti.com, patches@opensource.wolfsonmicro.com, bardliao@realtek.com, linux-omap@vger.kernel.org, lee.jones@linaro.org, support.opensource@diasemi.com Subject: Re: [alsa-devel] [PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write / register_patch Message-ID: <20150716154525.GB21939@opensource.wolfsonmicro.com> References: <1436885152-19850-1-git-send-email-nariman@opensource.wolfsonmicro.com> <20150716125254.GE4039@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150716125254.GE4039@sirena.org.uk> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2015 at 01:52:54PM +0100, Mark Brown wrote: > On Tue, Jul 14, 2015 at 03:45:51PM +0100, Nariman Poushin wrote: > > Please submit patches in the format covered in SubmittingPatches, > version information goes inside the []. > > > Add support for writing sequences of registers / patches with specified > > delays (in microseconds). Logically separates the functionality using > > sequences of register writes from the functions that take register > > defaults, as adding a delay field on the reg_defaults can increase > > memory usage substantially. > > This change doesn't do what the above changelog says. It introduces a > new struct reg_sequence and updates the multi write and patch APIs to > use that but it doesn't implement any delay functionality. Please > resend with a clearer changelog that describes why the struct is being > split out from the reg_defaults struct and makes it clear that this is > just a rename. It's probably best to also defer the addition of the > delay field until the second patch where this function is actually > implemented. > > > +/** > > + * Register / Value pairs for sequences of writes, incorporating an optional > > Register/value. > > > + * delay in microseconds. > > + * > > + * @reg: Register address. > > + * @def: Register default value. > > + * @delay_us: Delay in microseconds > > + */ > > + > > +struct reg_sequence { > > No blank line between the kerneldoc and the struct (as is the style for > other kernel code). I realized that I resent my patches with out outlining the changes from the previous patch set (V5 vs V4), not sure if it is best to resend with a cover letter (which would increase noise)? Anyway, I addressed your both your and Takashi's comments, thanks both for your feedback. I will resend with a cover letter explaining the change from the previous patch set if that is the right thing to do. Thanks Nariman > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel