From: Andy Whitcroft <apw@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-kernel@vger.kernel.org, Dan Carpenter <error27@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Checkpatch: False positive
Date: Thu, 16 Jul 2015 18:21:24 +0100 [thread overview]
Message-ID: <20150716172124.GK3681@bark> (raw)
In-Reply-To: <1437062336.2495.6.camel@perches.com>
On Thu, Jul 16, 2015 at 08:58:56AM -0700, Joe Perches wrote:
> On Thu, 2015-07-16 at 16:43 +0100, Andy Whitcroft wrote:
> > On Thu, Jul 16, 2015 at 08:35:58AM -0700, Joe Perches wrote:
> > > > #31:
> > > > arch/x86/kernel/hpet.c | 198 ++++++++++++++++++++++++++---------------
> >
> > I guess those are in the limbo land between the end of message and
> > beginning of the patch itself. Perhaps the test should at least stop at
> > the end of header marker, at the '---'.
> >
> > -apw
>
> Maybe, but the test already stops at signatures like
> Signed-off-by: that should always be above the ---.
>
> This might help, but there are _many_ false positives.
>
> The other thing that might help is for people to take
> the warnings the script produces less seriously.
>
> Maybe convert:
>
> ERROR -> defect
> WARNING -> unstylish
> CHECK -> nitpick
Heh, that has long been the main issue, please please believe your brain
not checkpatch. But yes some less inflamitory words might, just might,
reduce the noise.
-apw
next prev parent reply other threads:[~2015-07-16 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 10:55 Checkpatch: False positive Viresh Kumar
2015-07-16 15:35 ` Joe Perches
2015-07-16 15:43 ` Andy Whitcroft
2015-07-16 15:58 ` Joe Perches
2015-07-16 17:21 ` Andy Whitcroft [this message]
[not found] <54461602.4000705@redhat.com>
2014-10-21 8:28 ` checkpatch false positive Joe Perches
2014-10-21 9:27 ` Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2010-08-11 16:35 Dave Jones
2010-03-17 11:00 Richard Kennedy
2010-03-17 11:53 ` Andy Whitcroft
2010-03-17 15:25 ` Joe Perches
2010-03-17 15:40 ` Richard Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716172124.GK3681@bark \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox