From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755850AbbGPUNz (ORCPT ); Thu, 16 Jul 2015 16:13:55 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20614 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755441AbbGPUNx (ORCPT ); Thu, 16 Jul 2015 16:13:53 -0400 Date: Thu, 16 Jul 2015 23:13:43 +0300 From: Dan Carpenter To: Craig Inches Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Drivers: Staging: dgnc: Fix Style Issues Message-ID: <20150716201343.GB1148@mwanda> References: <1437102204-32016-1-git-send-email-craig.inches@xayto.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437102204-32016-1-git-send-email-craig.inches@xayto.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2015 at 03:03:24AM +0000, Craig Inches wrote: > Fixed multiple instances of: > > CHECK: Alignment should match open parenthesis > CHECK: Blank lines aren't necessary before a close brace '}' > CHECK: Please don't use multiple blank lines > CHECK: Blank lines aren't necessary after an open brace '{' > WARNING: line over 80 characters > Split the patch into 5 patches. > @@ -186,18 +191,23 @@ int dgnc_tty_register(struct dgnc_board *brd) > brd->SerialDriver.subtype = SERIAL_TYPE_NORMAL; > brd->SerialDriver.init_termios = DgncDefaultTermios; > brd->SerialDriver.driver_name = DRVSTR; > - brd->SerialDriver.flags = (TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV | TTY_DRIVER_HARDWARE_BREAK); > + brd->SerialDriver.flags = (TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV > + | TTY_DRIVER_HARDWARE_BREAK); The operator goes on the end. brd->SerialDriver.flags = (TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV | TTY_DRIVER_HARDWARE_BREAK); > kref_init(&brd->PrintDriver.kref); > - brd->PrintDriver.termios = kcalloc(brd->maxports, sizeof(*brd->PrintDriver.termios), GFP_KERNEL); > + brd->PrintDriver.termios = kcalloc(brd->maxports, > + sizeof(*brd->PrintDriver.termios), > + GFP_KERNEL); Not aligned correctly. > if (ch->ch_tun.un_flags & UN_ISOPEN) { > if ((ch->ch_tun.un_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) && > - ch->ch_tun.un_tty->ldisc->ops->write_wakeup) { > - spin_unlock_irqrestore(&ch->ch_lock, flags); > - (ch->ch_tun.un_tty->ldisc->ops->write_wakeup)(ch->ch_tun.un_tty); > - spin_lock_irqsave(&ch->ch_lock, flags); > + ch->ch_tun.un_tty->ldisc->ops->write_wakeup) { > + spin_unlock_irqrestore(&ch->ch_lock, flags); > + (ch->ch_tun.un_tty->ldisc->ops->write_wakeup) > + (ch->ch_tun.un_tty); > + spin_lock_irqsave(&ch->ch_lock, flags); > } This isn't correct at all. regards, dan carpenter