From: Mark Brown <broonie@kernel.org>
To: Nariman Poushin <nariman@opensource.wolfsonmicro.com>
Cc: gregkh@linuxfoundation.org, airlied@linux.ie,
dmitry.torokhov@gmail.com, sameo@linux.intel.com,
lee.jones@linaro.org, tony@atomide.com, lgirdwood@gmail.com,
brian.austin@cirrus.com, Paul.Handrigan@cirrus.com,
support.opensource@diasemi.com, bardliao@realtek.com,
oder_chiou@realtek.com,
laurent.pinchart+renesas@ideasonboard.com, lars@metafoo.de,
dmurphy@ti.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
patches@opensource.wolfsonmicro.com, linux-omap@vger.kernel.org,
alsa-devel@alsa-project.org, peter.ujfalusi@ti.com
Subject: Re: [PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch
Date: Thu, 16 Jul 2015 21:55:22 +0100 [thread overview]
Message-ID: <20150716205522.GC1602@sirena.org.uk> (raw)
In-Reply-To: <1437060982-26519-2-git-send-email-nariman@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Thu, Jul 16, 2015 at 04:36:22PM +0100, Nariman Poushin wrote:
> +
> + if (regs[i].delay_us)
> + udelay(regs[i].delay_us);
This is a bit funky. While Takashi is correct that we could be running
in a spinlock equally this will mean that we could end up with some
really long busy waits. It feels like we should at least make an effort
to complain about that, print a warning or something.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-16 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 15:36 [PATCH 1/2 V5] regmap: Use reg_sequence for multi_reg_write / register_patch Nariman Poushin
2015-07-16 15:36 ` [PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch Nariman Poushin
2015-07-16 20:55 ` Mark Brown [this message]
2015-07-16 21:07 ` Applied "regmap: Apply optional delay in multi_reg_write/register_patch" to the regmap tree Mark Brown
2015-07-16 21:07 ` Applied "regmap: Use reg_sequence for multi_reg_write / register_patch" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716205522.GC1602@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=brian.austin@cirrus.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nariman@opensource.wolfsonmicro.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox