From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756329AbbGPV3f (ORCPT ); Thu, 16 Jul 2015 17:29:35 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:51922 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756277AbbGPV3c (ORCPT ); Thu, 16 Jul 2015 17:29:32 -0400 X-Helo: d01dlp02.pok.ibm.com X-MailFrom: sukadev@linux.vnet.ibm.com X-RcptTo: sparclinux@vger.kernel.org Date: Thu, 16 Jul 2015 14:28:18 -0700 From: Sukadev Bhattiprolu To: Peter Zijlstra Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces Message-ID: <20150716212818.GA31962@us.ibm.com> References: <1436929315-28520-1-git-send-email-sukadev@linux.vnet.ibm.com> <1436929315-28520-4-git-send-email-sukadev@linux.vnet.ibm.com> <20150716201749.GL3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150716201749.GL3644@twins.programming.kicks-ass.net> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071621-0033-0000-0000-0000052E477F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra [peterz@infradead.org] wrote: | On Tue, Jul 14, 2015 at 08:01:50PM -0700, Sukadev Bhattiprolu wrote: | > @@ -1604,6 +1613,12 @@ static void power_pmu_start_txn(struct pmu *pmu) | > static void power_pmu_cancel_txn(struct pmu *pmu) | > { | > struct cpu_hw_events *cpuhw = this_cpu_ptr(&cpu_hw_events); | > + int txn_flags; | > + | > + txn_flags = cpuhw->txn_flags; | > + cpuhw->txn_flags = 0; | > + if (cpuhw->txn_flags & ~PERF_PMU_TXN_ADD) | > + return; | | That seems, unintentional? ;-) Argh. Thanks for catching it. Sukadev