From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945943AbbGQKjo (ORCPT ); Fri, 17 Jul 2015 06:39:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47148 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945920AbbGQKjn (ORCPT ); Fri, 17 Jul 2015 06:39:43 -0400 Date: Fri, 17 Jul 2015 11:39:39 +0100 From: Mel Gorman To: Sergey Senozhatsky Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush() Message-ID: <20150717103939.GD2561@suse.de> References: <1437113574-2047-1-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1437113574-2047-1-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2015 at 03:12:54PM +0900, Sergey Senozhatsky wrote: > tlb_flush contains TP_CONDITION(cpu_online(smp_processor_id())) > which is better be executed with preemption disabled. > > Move trace_tlb_flush(TLB_REMOTE_SHOOTDOWN) in try_to_unmap_flush() > under get_cpu(). > > Signed-off-by: Sergey Senozhatsky Your patch is valid but Sasha also had sent an almost identicial fix a few hours ago for identical reasons that Andrew picked up. Thanks for sending it in. -- Mel Gorman SUSE Labs