Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush()

Mel Gorman
2015-07-17T10:39:44Z

On Fri, Jul 17, 2015 at 03:12:54PM +0900, Sergey Senozhatsky wrote:
> tlb_flush contains TP_CONDITION(cpu_online(smp_processor_id()))
> which is better be executed with preemption disabled.
>
> Move trace_tlb_flush(TLB_REMOTE_SHOOTDOWN) in try_to_unmap_flush()
> under get_cpu().
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Your patch is valid but Sasha also had sent an almost identicial fix a few
hours ago for identical reasons that Andrew picked up. Thanks for sending
it in.

--
Mel Gorman
SUSE Labs