public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: kaixu xia <xiakaixu@huawei.com>
Cc: ast@plumgrid.com, davem@davemloft.net, acme@kernel.org,
	mingo@redhat.com, masami.hiramatsu.pt@hitachi.com,
	jolsa@kernel.org, wangnan0@huawei.com,
	linux-kernel@vger.kernel.org, pi3orama@163.com,
	hekuang@huawei.com
Subject: Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map
Date: Fri, 17 Jul 2015 13:06:23 +0200	[thread overview]
Message-ID: <20150717110623.GK12596@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1437129816-13176-4-git-send-email-xiakaixu@huawei.com>

On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index e965cfa..c4e34b7 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -8582,6 +8582,28 @@ void perf_event_delayed_put(struct task_struct *task)
>  		WARN_ON_ONCE(task->perf_event_ctxp[ctxn]);
>  }
>  
> +struct perf_event *perf_event_get(unsigned int fd)
> +{
> +	struct perf_event *event;
> +	struct fd f;
> +
> +	f = fdget(fd);
> +
> +	if (!f.file)
> +		return ERR_PTR(-EBADF);
> +
> +	if (f.file->f_op != &perf_fops) {
> +		fdput(f);
> +		return ERR_PTR(-EINVAL);
> +	}
> +
> +	event = f.file->private_data;
> +
> +	fdput(f);
> +
> +	return event;
> +}

And what is stopping userspace from closing those FDs while you're using
them?

  reply	other threads:[~2015-07-17 11:06 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 10:43 [RFC PATCH 0/6] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter kaixu xia
2015-07-17 10:43 ` [RFC PATCH 1/6] bpf: Add new flags that specify the value type stored in map kaixu xia
2015-07-17 10:43 ` [RFC PATCH 2/6] bpf: Add function map->ops->map_traverse_elem() to traverse map elems kaixu xia
2015-07-17 10:43 ` [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map kaixu xia
2015-07-17 11:06   ` Peter Zijlstra [this message]
2015-07-17 11:21     ` Wangnan (F)
2015-07-17 11:34       ` Wangnan (F)
2015-07-17 11:40         ` Peter Zijlstra
2015-07-17 11:54           ` Wangnan (F)
2015-07-17 12:02             ` Peter Zijlstra
2015-07-17 12:07               ` Wangnan (F)
2015-07-17 11:37   ` Peter Zijlstra
2015-07-17 10:43 ` [RFC PATCH 4/6] bpf: Add a bpf program function argument constraint for PMU map kaixu xia
2015-07-17 10:43 ` [RFC PATCH 5/6] bpf: Implement function bpf_read_pmu() that get the selected hardware PMU conuter kaixu xia
2015-07-17 11:05   ` Peter Zijlstra
2015-07-17 11:29     ` Wangnan (F)
2015-07-17 11:39       ` Peter Zijlstra
2015-07-17 11:45         ` Wangnan (F)
2015-07-17 11:55           ` Peter Zijlstra
2015-07-17 11:56             ` Peter Zijlstra
2015-07-17 12:01               ` Wangnan (F)
2015-07-17 12:04                 ` Wangnan (F)
2015-07-17 12:18                 ` Peter Zijlstra
2015-07-17 12:27                   ` Wangnan (F)
2015-07-17 12:45                     ` Peter Zijlstra
2015-07-17 12:46                       ` Peter Zijlstra
2015-07-17 12:57                       ` pi3orama
2015-07-17 13:26                         ` Peter Zijlstra
2015-07-17 13:45                           ` pi3orama
2015-07-17 11:33     ` Peter Zijlstra
2015-07-17 10:43 ` [RFC PATCH 6/6] samples/bpf: example of get selected PMU counter value kaixu xia
2015-07-17 22:56 ` [RFC PATCH 0/6] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter Alexei Starovoitov
2015-07-17 23:27   ` pi3orama
2015-07-18  0:42     ` Alexei Starovoitov
2015-07-18  1:02       ` pi3orama
2015-07-18  1:22         ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717110623.GK12596@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    --cc=xiakaixu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox