From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753935AbbGQLUh (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jul 2015 07:20:37 -0400
Received: from mail-pa0-f43.google.com ([209.85.220.43]:33284 "EHLO
	mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750811AbbGQLUg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jul 2015 07:20:36 -0400
Date: Fri, 17 Jul 2015 20:19:43 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush()
Message-ID: <20150717111943.GA636@swordfish>
References: <1437113574-2047-1-git-send-email-sergey.senozhatsky@gmail.com>
 <20150717103939.GD2561@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150717103939.GD2561@suse.de>
User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (07/17/15 11:39), Mel Gorman wrote:
> On Fri, Jul 17, 2015 at 03:12:54PM +0900, Sergey Senozhatsky wrote:
> > tlb_flush contains TP_CONDITION(cpu_online(smp_processor_id()))
> > which is better be executed with preemption disabled.
> > 
> > Move trace_tlb_flush(TLB_REMOTE_SHOOTDOWN) in try_to_unmap_flush()
> > under get_cpu().
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> Your patch is valid but Sasha also had sent an almost identicial fix a few
> hours ago for identical reasons that Andrew picked up. Thanks for sending
> it in.

Oh, didn't know that. Thanks.

	-ss