From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754057AbbGQLZY (ORCPT ); Fri, 17 Jul 2015 07:25:24 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:36732 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbbGQLZX (ORCPT ); Fri, 17 Jul 2015 07:25:23 -0400 Date: Fri, 17 Jul 2015 16:55:12 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] staging: rtl8188eu: remove goto label Message-ID: <20150717112512.GA4808@sudip-PC> References: <1437046092-16363-1-git-send-email-sudipm.mukherjee@gmail.com> <1437046092-16363-3-git-send-email-sudipm.mukherjee@gmail.com> <20150717110348.GC5371@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150717110348.GC5371@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > By checking for the success of kzalloc we were able to remove the goto > > label thus making the code more readable. > > > > No... You've just changed error handling to success handling and added > some new indent levels and made a tangled spaghetti exit path even more > tangled. Spoderman wants to know, "Why u do dis?" I had to go for google to lookup Spoderman or Spiderman. :) At the end of the series, isn't the code better looking and simpler than the original code? regards sudip