From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757363AbbGQMDb (ORCPT ); Fri, 17 Jul 2015 08:03:31 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35067 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280AbbGQMDa (ORCPT ); Fri, 17 Jul 2015 08:03:30 -0400 Date: Fri, 17 Jul 2015 17:33:19 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] staging: rtl8188eu: remove goto label Message-ID: <20150717120243.GA5545@sudip-PC> References: <1437046092-16363-1-git-send-email-sudipm.mukherjee@gmail.com> <1437046092-16363-3-git-send-email-sudipm.mukherjee@gmail.com> <20150717110348.GC5371@mwanda> <20150717112512.GA4808@sudip-PC> <20150717114755.GB5422@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150717114755.GB5422@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2015 at 02:47:55PM +0300, Dan Carpenter wrote: > On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote: > > On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > > > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > > > By checking for the success of kzalloc we were able to remove the goto > > > > label thus making the code more readable. > > > > > > > > > > No... You've just changed error handling to success handling and added > > > some new indent levels and made a tangled spaghetti exit path even more > > > tangled. Spoderman wants to know, "Why u do dis?" > > I had to go for google to lookup Spoderman or Spiderman. :) > > At the end of the series, isn't the code better looking and simpler > > than the original code? > > Yes, but that's not a very high bar to clear. > > What I'm trying to explain is the beauty of writing one statement after > the other without indenting. understood. I was planning another series for that file so i will include one for this also. But before that I am going to send in the patch for sm7xxfb to move out of staging. Please check that. regards sudip