From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Laura Abbott <labbott@fedoraproject.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after resume
Date: Fri, 17 Jul 2015 14:14:46 +0200 [thread overview]
Message-ID: <20150717121446.GA11210@gmail.com> (raw)
In-Reply-To: <20150717083953.GA27348@nazgul.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> > EXPORT_SYMBOL_GPL(__static_cpu_has_safe);
> > +
> > +static void cpu_custom_resume(void)
>
> Let's call this bsp_resume() as it is run only on the boot CPU.
>
> > +{
> > + if (this_cpu->c_resume)
> > + this_cpu->c_resume(&boot_cpu_data);
> > +}
>
> So giving boot_cpu_data means, this is the boot CPU but you're assigning it to
> c_resume() which means, every CPU. What you could do is call the function ptr
> ->c_bsp_resume like the ->c_bsp_init which we already have so that it is clear
> that it is run only on the BSP.
>
> Rest looks ok to me, unless tip guys have a better idea...
Looks good to me!
Ingo
prev parent reply other threads:[~2015-07-17 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 22:09 [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after resume Laura Abbott
2015-07-17 8:39 ` Borislav Petkov
2015-07-17 12:14 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717121446.GA11210@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox