Re: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers

[Olof Johansson <olof@lixom.net>]

On Thu, Jul 16, 2015 at 09:42:47AM +0900, Krzysztof Kozlowski wrote:
> On 16.07.2015 00:38, Javier Martinez Canillas wrote:
> > Hello,
> > 
> > On Thu, May 14, 2015 at 5:40 PM, Javier Martinez Canillas
> > <javier.martinez@collabora.co.uk> wrote:
> >> The Maxim max77802 Power Management IC is used on many Exynos machines.
> >> Besides a bunch of regulators, this chip has a Real-Time-Clock (RTC)
> >> and 2-channel 32kHz clock outputs.
> >>
> >> Enable the kernel config options to have the drivers for these devices
> >> built as a module.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> >> ---
> >>  arch/arm/configs/multi_v7_defconfig | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> >> index 2349584b6e08..080120fe5580 100644
> >> --- a/arch/arm/configs/multi_v7_defconfig
> >> +++ b/arch/arm/configs/multi_v7_defconfig
> >> @@ -373,6 +373,7 @@ CONFIG_POWER_RESET_SYSCON=y
> >>  CONFIG_REGULATOR_MAX8907=y
> >>  CONFIG_REGULATOR_MAX8973=y
> >>  CONFIG_REGULATOR_MAX77686=y
> >> +CONFIG_REGULATOR_MAX77802=m
> > 
> > I noticed that the version that landed in 4.2-rc1 as commit
> > f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 regulator, rtc
> > and clock drivers") doesn't include this symbol. I guess it was caused
> > by a wrong resolved conflict? I'll post a patch to enable the
> > regulator again.
> 
> As you can see in mentioned mainline commit Kukjin removed it manually:
> [kgene@kernel.org: removing useless REGULATOR_MAX77802 config]
> 
> I wonder why?

Seems odd. exynos_defconfig still enables it.

Javier or Krzysztof, please send an incremental fix to enable and I'll pick
it up as a fix.


-Olof