From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756199AbbGRAyJ (ORCPT ); Fri, 17 Jul 2015 20:54:09 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33736 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756163AbbGRAyG (ORCPT ); Fri, 17 Jul 2015 20:54:06 -0400 Date: Sat, 18 Jul 2015 09:53:10 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH v2] zsmalloc: do not take class lock in zs_shrinker_count() Message-ID: <20150718005310.GA638@swordfish> References: <1437131898-2231-1-git-send-email-sergey.senozhatsky@gmail.com> <20150717224233.GA7334@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150717224233.GA7334@blaptop> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On (07/18/15 07:42), Minchan Kim wrote: > I asked to remove the comment of zs_can_compact about lock. > "Should be called under class->lock." Oh... I somehow quickly read it and thought you were talking about the commit message. Fixed and resent. > Otherwise, > > Acked-by: Minchan Kim Thanks. -ss > > --- > > mm/zsmalloc.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index 1edd8a0..ed64cf5 100644 > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -1836,9 +1836,7 @@ static unsigned long zs_shrinker_count(struct shrinker *shrinker, > > if (class->index != i) > > continue; > > > > - spin_lock(&class->lock); > > pages_to_free += zs_can_compact(class); > > - spin_unlock(&class->lock); > > } > > > > return pages_to_free; > > -- > > 2.4.6 > > > > -- > Kind regards, > Minchan Kim >