From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754044AbbGSWAx (ORCPT ); Sun, 19 Jul 2015 18:00:53 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35947 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753579AbbGSWAw (ORCPT ); Sun, 19 Jul 2015 18:00:52 -0400 Date: Mon, 20 Jul 2015 00:00:48 +0200 From: Alexandre Belloni To: rnd4@dave-tech.it Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Andrea Scian Subject: Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code when reading date/time Message-ID: <20150719220048.GA15539@piout.net> References: <557EF5DD.9070300@dave-tech.it> <1434447319-23007-1-git-send-email-rnd4@dave-tech.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434447319-23007-1-git-send-email-rnd4@dave-tech.it> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2015 at 11:35:19 +0200, rnd4@dave-tech.it wrote : > From: Andrea Scian > > There's a wrong commend in some RTC driver that say it's better to ignore > rtc_valid_tm() when reading RTC timestamp. However this is wrong and is > better to return to the userspace the an error if timestamp is not valid. > > Signed-off-by: Andrea Scian > --- > drivers/rtc/rtc-isl12022.c | 7 +------ > drivers/rtc/rtc-pcf2123.c | 8 +------- > drivers/rtc/rtc-pcf2127.c | 8 +------- > drivers/rtc/rtc-pcf8563.c | 8 +------- > 4 files changed, 4 insertions(+), 27 deletions(-) > Applied, after dropping the pcf8563 part as it was part of another patch. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com