From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932638AbbGTIKd (ORCPT ); Mon, 20 Jul 2015 04:10:33 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36868 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932588AbbGTIKZ (ORCPT ); Mon, 20 Jul 2015 04:10:25 -0400 Date: Mon, 20 Jul 2015 09:10:20 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sergei Shtylyov , Mark Brown , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property Message-ID: <20150720081020.GD3061@x1> References: <1437114567-17629-1-git-send-email-javier@osg.samsung.com> <1437114567-17629-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1437114567-17629-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jul 2015, Javier Martinez Canillas wrote: > The regulator-compatible property from the regulator DT binding was > deprecated. But the max77686 DT binding doc still suggest to use it > instead of the regulator node name's which is the correct approach. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski By convention shouldn't this be buck@1, or something? Need Mark to look at this. > --- > > Changes in v2: > - Add Krzysztof Kozlowski Reviewed-by tag in patch #1. > > Documentation/devicetree/bindings/mfd/max77686.txt | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt > index 163bd81a4607..8221102d3fc2 100644 > --- a/Documentation/devicetree/bindings/mfd/max77686.txt > +++ b/Documentation/devicetree/bindings/mfd/max77686.txt > @@ -26,7 +26,7 @@ Optional node: > }; > refer Documentation/devicetree/bindings/regulator/regulator.txt > > - The regulator-compatible property of regulator should initialized with string > + The regulator node's name should be initialized with a string > to get matched with their hardware counterparts as follow: > > -LDOn : for LDOs, where n can lie in range 1 to 26. > @@ -55,16 +55,14 @@ Example: > reg = <0x09>; > > voltage-regulators { > - ldo11_reg { > - regulator-compatible = "LDO11"; > + ldo11_reg: LDO11 { > regulator-name = "vdd_ldo11"; > regulator-min-microvolt = <1900000>; > regulator-max-microvolt = <1900000>; > regulator-always-on; > }; > > - buck1_reg { > - regulator-compatible = "BUCK1"; > + buck1_reg: BUCK1 { > regulator-name = "vdd_mif"; > regulator-min-microvolt = <950000>; > regulator-max-microvolt = <1300000>; > @@ -72,8 +70,7 @@ Example: > regulator-boot-on; > }; > > - buck9_reg { > - regulator-compatible = "BUCK9"; > + buck9_reg: BUCK9 { > regulator-name = "CAM_ISP_CORE_1.2V"; > regulator-min-microvolt = <1000000>; > regulator-max-microvolt = <1200000>; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog