From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Francesco Lavra <francescolavra.fl@gmail.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: sunxi: fix activation of system reset
Date: Mon, 20 Jul 2015 10:26:58 +0200 [thread overview]
Message-ID: <20150720082658.GU28632@lukather> (raw)
In-Reply-To: <559AC20B.4090601@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
Hi Francesco,
Your patch looks mostly good, but there's just a few minor things.
On Mon, Jul 06, 2015 at 07:59:39PM +0200, Francesco Lavra wrote:
> Commit f2147de3 ("watchdog: sunxi: support parameterized compatible
The commit ID should have at least 12 chars to avoid future ID
collisions (which already start to happen)
> strings") introduced a regression in sunxi_wdt_start(), by which
> the system reset function of the watchdog is not enabled upon
> starting the watchdog. Fix it.
Having a description of what that actually means for the end-user (I
guess that it won't reset the system when the watchdog expires) would
be nice.
> Signed-off-by: Francesco Lavra <francescolavra.fl@gmail.com>
Could you also CC stable, and add a Fixes: tag please?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-20 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 17:59 [PATCH] watchdog: sunxi: fix activation of system reset Francesco Lavra
2015-07-06 20:24 ` Guenter Roeck
2015-07-20 8:26 ` Maxime Ripard [this message]
2015-07-25 5:59 ` Francesco Lavra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720082658.GU28632@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=francescolavra.fl@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox