From: Oleg Nesterov <oleg@redhat.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Jeff Moyer <jmoyer@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <js1304@gmail.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix
Date: Mon, 20 Jul 2015 21:24:40 +0200 [thread overview]
Message-ID: <20150720192440.GA20573@redhat.com> (raw)
In-Reply-To: <20150720183150.GA6868@redhat.com>
On 07/20, Oleg Nesterov wrote:
>
> But again, again, please ignore. This all is off-topic and my understanding
> is very limited.
Yes, yes, but sorry for noise and let me repeat...
This memory lives in page-cache/lru, it is visible for shrinker which
will unmap these pages for no reason on memory shortage. IOW, aio fools
the kernel, this memory looks reclaimable but it is not. And we only do
this for migration.
Even if this is not a problem, this does not look right. So perhaps at
least mapping_set_unevictable() makes sense. But I simply do not know
if migration will work with this change.
And I should have changes the subject a long ago... So what do you think
we should do with the build failure?
Oleg.
next prev parent reply other threads:[~2015-07-20 19:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 23:14 [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov
2015-07-16 23:22 ` Stephen Rothwell
2015-07-16 23:24 ` Andrew Morton
2015-07-16 23:52 ` Oleg Nesterov
2015-07-17 14:06 ` Benjamin LaHaise
2015-07-17 17:27 ` Oleg Nesterov
2015-07-17 17:37 ` Benjamin LaHaise
2015-07-17 17:55 ` Oleg Nesterov
2015-07-17 18:12 ` Austin S Hemmelgarn
2015-07-17 18:19 ` Oleg Nesterov
2015-07-17 18:39 ` Austin S Hemmelgarn
2015-07-17 18:54 ` Oleg Nesterov
2015-07-17 19:09 ` Austin S Hemmelgarn
2015-07-17 22:56 ` Oleg Nesterov
2015-07-17 22:31 ` Oleg Nesterov
2015-07-20 14:22 ` Jeff Moyer
2015-07-20 17:33 ` Oleg Nesterov
2015-07-20 17:51 ` Benjamin LaHaise
2015-07-20 18:30 ` Jeff Moyer
2015-07-20 18:31 ` Oleg Nesterov
2015-07-20 19:24 ` Oleg Nesterov [this message]
2015-07-20 19:39 ` Benjamin LaHaise
2015-07-20 20:03 ` Oleg Nesterov
2015-07-21 15:29 ` [PATCH v2] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov
2015-07-21 15:38 ` Benjamin LaHaise
2015-07-21 16:18 ` Oleg Nesterov
2015-07-21 16:20 ` [PATCH v3] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720192440.GA20573@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jmoyer@redhat.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).